Review main Merged

66067[TASK] Do not call determineId() twice

Benni Mack CR +2 V +2 Easy +9 −23 updated 10/08/20, 18:58

Commit message

Due to legacy reasons before PSR-15 middlewares were introduced,
there was a hook to re-evaluate the Page ID via TSFE->determineId()
which was popular with RealURL.

$TSFE->determineId() was called twice when logged-in backend users
were accessing a page they did not have access to, with a clean state,
however TSFE->determineId() does the same check already as well,
so it is not needed to call determineId() twice anymore, because the
hook was removed in TYPO3 v10.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2