Review main Merged Breaking

66070[!!!][TASK] Make Extbase handle PSR-7 responses only

Alexander Schnitzler CR +2 V +2 Hard +190 −660 updated 11/06/20, 08:51

Commit message

With this patch, Extbase does no longer handle/return
extbase responses whose api was defined by the extbase
ResponseInterfacer. Instead, Extbase does create a PSR-7
compatible response object and passes it back through
the request handling stack.

Since PSR-7 requires response objects to be immutable,
the response object is no longer accessible as property
of class ActionController. It is also no longer accessible
through the ControllerContext class. In fact, the response
is completely hidden from the user and can no longer be
changed.

To address this issue, an upcoming patch will enable users
to return user controlled responses from within controller
actions instead of just returning content strings. User will
then be forced to return response objects with the content
and all necessary headers, such as the content-type, set.

Since the Response class has been deleted, it is no longer
usable in user land code. It should be replaced with PSR-7
compatible response objects to stay compatible with response
handlers of both the core and extbase.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 27

Show 7 more files