66074[TASK] Improve error messages for linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benni Mack +2
- Stefan Bürk +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 3144
Show 1319 earlier messages
-
Sybille Peters uploaded patch set 1 10/07/20, 17:47
-
TYPO3com voted on patch set 1 V +1 10/07/20, 18:01 Completed build in 14m 01s on Wed, 7 Oct, 06:01 PM Test Summary: 73788 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6336
-
Sybille Peters wrote 10/23/20, 17:17
Topic set to Linkvalidator -
Sybille Peters uploaded patch set 2 10/25/20, 18:06
-
TYPO3com voted on patch set 2 V -1 10/25/20, 18:18 Completed build in 11m 54s on Sun, 25 Oct, 06:18 PM Test Summary: 1 of 74045 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6878
-
TYPO3com voted on patch set 2 V +1 10/25/20, 19:13 Completed build in 13m 47s on Sun, 25 Oct, 07:13 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6879
-
Daniel Goerz commented on patch set 2 10/26/20, 09:01
LinktypeInterface.php:80Adding a method to an interface is a breaking change. So this could only happen in master. -
Alexander Schnitzler commented on patch set 2 CR -1 10/26/20, 09:45
AbstractLinktype.php:83Please add a type hint here.ExternalLinktype.php:284Please add a type hint here.ExternalLinktype.php:286Please do not use a boolean comparison on non booleans. This means, if you want to check for an empty array, please do so: > if ($errorParams === []) -
Sybille Peters uploaded patch set 3 10/26/20, 17:31
-
Sybille Peters uploaded patch set 4 10/26/20, 17:33
-
Sybille Peters commented on patch set 4 10/26/20, 17:37
AbstractLinktype.php:83ReplyDoneExternalLinktype.php:284ReplyDoneExternalLinktype.php:286ReplyDoneLinktypeInterface.php:80ReplyChanged to master only and added a Changelog for breaking. -
Sybille Peters uploaded patch set 5 10/26/20, 17:41
-
TYPO3com voted on patch set 3 V +1 10/26/20, 17:43 Completed build in 12m 28s on Mon, 26 Oct, 05:43 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6896
-
TYPO3com voted on patch set 4 V +1 10/26/20, 17:50 Completed build in 16m 30s on Mon, 26 Oct, 05:50 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6897
-
TYPO3com voted on patch set 5 V +1 10/26/20, 17:54 Completed build in 13m 13s on Mon, 26 Oct, 05:54 PM Test Summary: 73560 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6898
-
Oliver Klee commented on patch set 5 10/26/20, 18:20
AbstractLinktype.php:79Should we have an @param annotation with array<string, string> here? This should help static type checkers. (Ditto for the interface and all classes implementing the interface.)AbstractLinktype.php:83If I read this code correctly, we can discard these 3 lines, and the result will still be the same. -
Sybille Peters commented on patch set 5 10/26/20, 18:37
AbstractLinktype.php:83ReplyIf $errorParams is passed, he will use exception from that, if not $this->errorParams is used. -
Oliver Klee commented on patch set 5 10/26/20, 19:01
AbstractLinktype.php:83ReplyAh, I missed that. Thanks! -
Sybille Peters marked it work in progress 10/31/20, 13:35
-
Sybille Peters uploaded patch set 6 10/31/20, 16:02
-
Sybille Peters uploaded patch set 7 10/31/20, 16:05
-
TYPO3com voted on patch set 6 V -1 10/31/20, 16:14 Completed build in 11m 59s on Sat, 31 Oct, 04:14 PM Test Summary: 6 of 74042 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7056
-
TYPO3com commented on patch set 7 10/31/20, 16:19 Completed build in 14m 32s on Sat, 31 Oct, 04:19 PM Test Summary: 6 of 74042 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7057
-
Sybille Peters uploaded patch set 8 10/31/20, 18:10
-
TYPO3com voted on patch set 8 V +1 10/31/20, 18:22 Completed build in 12m 01s on Sat, 31 Oct, 06:22 PM Test Summary: 73557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7058
-
Sybille Peters commented on patch set 8 11/03/20, 14:47
I significantly changed the patch. It is no longer necessary to add an additional function for the exception message (that might be done additionally in a separate patch, but is not strictly necessary). The main goal of the patch was to add more short, non-technical and localizable error messages and to get rid of misleading or wrong error messages. -
Sybille Peters commented on patch set 8 11/03/20, 14:51
AbstractLinktype.php:83ReplyDone - no longer applies as patch has been changed to not need the new function.ExternalLinktype.php:284ReplyDone - no longer applies as patch has been changed to not need the new function. -
Sybille Peters uploaded patch set 9 11/05/20, 16:34
-
TYPO3com voted on patch set 9 V -1 11/05/20, 16:50 Completed build in 15m 29s on Thu, 5 Nov, 04:50 PM Test Summary: 72050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7135
-
TYPO3com voted on patch set 9 V +1 11/05/20, 17:07 Completed build in 13m 09s on Thu, 5 Nov, 05:07 PM Test Summary: 73593 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7136
-
Sybille Peters uploaded patch set 10 11/20/20, 15:38
-
TYPO3com voted on patch set 10 V +1 11/20/20, 16:06 Completed build in 11m 44s on Fri, 20 Nov, 04:05 PM Test Summary: 32389 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7481
-
Christian Kuhn commented on patch set 10 CR -1 11/20/20, 16:32
ExternalLinktype.php:38those constants should be protected and the usage in the test file should be dropped (just use the value) -
Sybille Peters uploaded patch set 11 11/20/20, 18:18
-
Sybille Peters commented on patch set 11 11/20/20, 18:19
ExternalLinktype.php:38ReplyDone -
Sybille Peters wrote 11/20/20, 18:19
Description set to "Fixes based on comment" -
TYPO3com voted on patch set 11 V +1 11/20/20, 18:30 Completed build in 11m 25s on Fri, 20 Nov, 06:30 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7493
-
Benni Mack voted on patch set 11 CR +1 08/11/21, 09:21
-
Benni Mack voted on patch set 11 V +1 10/15/21, 07:33
-
Stefan Bürk voted on patch set 11 CR +1 10/24/21, 13:12
-
Stefan Bürk voted on patch set 11 V +1 10/24/21, 15:38
-
Benni Mack commented on patch set 11 V +2 CR +2 10/25/21, 12:30
AbstractLinktype.php:79ReplyDone -
Benni Mack merged patch set 12 10/25/21, 12:30
-
Stefan Bürk commented on patch set 12 04/11/25, 12:25
LinktypeInterface.php:80ReplyDone