Review main Merged

66077[TASK] Explicitly require PHPUnit 8

Helmut Hummel CR +2 V +2 Easy +17 −6 updated 10/08/20, 12:00

Commit message

The code in the test suite is based on PHPUnit 8
therefore using it with PHPUnit 9 will produce a lot of warnings
caused by deprecations.

The testing framework however allows installing PHPUnit 9,
which is fine, when the test suite itself can cope with that.

This is why we pin our tests to PHPUnit 8, until we adapt
them to properly work with PHPUnit 9

composer req --dev phpunit/phpunit ^8.5.2

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2