Review main Merged

66078[TASK] Stop JsonView from setting headers

Alexander Schnitzler CR +2 V +2 Normal +24 −73 updated 10/28/20, 23:00

Commit message

JsonView did set content type headers in its render method which
is a problem since the view should only be responsible for rendering
the content of the to be returned response.

The current approach, setting those headers in the action controller,
is just a temporary solution until Extbase is capable of handling
PSR-7 responses which then makes it superfluous to set headers
magically. Instead people will need to set headers manually or use
a JsonResponse object instead and let the core handle setting headers
further down in the request/response handling stack.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3