Review main Merged Breaking

66079[!!!][TASK] Request processing chain must return a response object

Alexander Schnitzler CR +2 V +2 Normal +111 −74 updated 10/23/20, 12:38

Commit message

This patch introduces a proper request/response handling chain. That
means, that Extbase no longer creates a response object early, passes
it through the request handler and dispatcher into the controller and
expects it to be altered there.

Instead, request handlers, the dispatcher and controllers only get
passed a request object and controllers are then responsible for
creating and returning a response.

This change is preparatory work for the introduction of PSR-7 responses
in Extbase. Those responses are immutable and can no longer passed by
reference through the stack. Instead, the controller must return the
desired response along with its state down the stack while remaining
unaltered.

This patch is considered breaking because it changes several method
signatures of public classes and interfaces.

Still, it is quite unlikely to be struck by this change when using
the public api of Extbase and not overriding classes such as the
ActionController.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 17