Review main Merged

66100[TASK] Decouple Dependency logic and domain models in EM

Benni Mack CR +2 V +2 Expert +635 −833 updated 10/12/20, 16:38

Commit message

Both Domain\Model\Extension and Domain\Model\Dependency now have
factory methods to avoid using the ExtensionModelUtility to build
objects in an atomic state.

This marks the ExtensionModelUtility class obsolete, which resolved
dependencies and built Dependency objects.

The Dependency object is now not an AbstractEntity anymore, but more
of a type ValueObject.

However, since the Dependency object knows about the min/max version
constraints, this logic is now shifted into this class, making the
DependencyUtility much smaller in logic.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 18