Review 10.4 Merged

66117[TASK] Provide information about mandatory `uid` field in PHPDoc

Benni Mack CR +2 V +2 Easy +10 −5 updated 10/13/20, 10:10

Commit message

A couple of functions in PageRepository allow to define the fields
to be selected. Because the `uid` is used internally to further
process the selected row, this field is mandatory and must be
present in a custom fields list.

This fact is now documented in all corresponding PHPDoc blocks.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 10/13/20, 09:45

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 10/13/20, 10:08 Completed build in 22m 35s on Tue, 13 Oct, 10:08 AM Test Summary: 74823 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-616

  3. Benni Mack voted on patch set 1 V +2 CR +2 10/13/20, 10:10

  4. Benni Mack merged patch set 2 10/13/20, 10:10