Review main Merged

66161[TASK] Deprecate last arguments of wrapClickMenuOnIcon()

Daniel Goerz CR +2 V +2 Normal +94 −14 updated 10/19/20, 18:36

Commit message

BackendUtility::wrapClickMenuOnIcon() has a boolean flag
to let the method return an array with tag parameters
instead of a fully build HTML tag as string.

As this are two completely different things and cause
problems when analysing return types it should not be
done in the same method.

Calling BackendUtility::wrapClickMenuOnIcon() with the
7th and last argument $returnTagParameters set to true
has been deprecated alongside the 5th and 6th arguments
that are already unused.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5