Review main Merged Breaking

66169[!!!][TASK] Return moved PID when overlaying versioned records

Benni Mack CR +2 V +2 Hard +229 −71 updated 10/19/20, 18:12

Commit message

In the past, the API methods:
* PageRepository->versionOL()
* BackendUtility::workspaceOL()

returned the PID of the moved record in a workspace in the field
_ORIG_PID and the live record value in "pid".

The methods "fixVersioningPid()" were used to return the
moved PID (of the versioned records) and set the "_ORIG_PID"
to the value of the live record.

This inconsistency can be overcome by simply using workspaceOL
returning the newly moved location as "pid" and keep the "_ORIG_pid"
of the live record for later purposes.

This way, fixVersioningPid is not needed anymore, if workspaceOL/versionOL
is applied. TYPO3 Core is not using the fixVersioningPid methods
anymore now and they are marked as deprecated.

As this is a breaking change ("behavior of overlay and value of _ORIG_pid")
an RST explains the new behavior.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 18