Review main Merged

66172[TASK] Clean up move placeholder comments and usages

Benni Mack CR +2 V +2 Normal +33 −56 updated 10/19/20, 09:21

Commit message

Since the move placeholder code is gone, some variables / methods
are still "cryptic" and some comments are outdated.

This change modifies some places to make the code
more readable for its current state.

In addition, the RootlineUtility code is now more focussed
and explained on the move pointer retrieval.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 10/19/20, 06:45

  2. Benni Mack commented on patch set 2 10/19/20, 06:46

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 1 V +1 10/19/20, 07:00 Completed build in 15m 34s on Mon, 19 Oct, 07:00 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6645

  4. TYPO3com voted on patch set 2 V +1 10/19/20, 07:04 Completed build in 13m 35s on Mon, 19 Oct, 07:04 AM Test Summary: 73812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6646

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 10/19/20, 07:43

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 10/19/20, 09:21

  7. Christian Kuhn merged patch set 3 10/19/20, 09:21