Review main Merged

66190[TASK] Deprecate GeneralUtility::uniqueList

Oli Bartsch CR +2 V +2 Normal +115 −45 updated 10/20/20, 16:48

Commit message

Since over a decade (according to the timestamp),
GeneralUtility::uniqueList() does not allow an array as
first argument and furthermore doesn't use the second
parameter anymore. Since then, both have thrown an
`InvalidArgumentException`. Furthermore, this method
does not belong to GeneralUtility at all.

Therefore this method is now deprecated and a new one,
using proper type hints, a return type, no second argument
and a correct PHPDoc is added to StringUtility.

All usages in the core are replaced with the new method,
ensuring proper types.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 8