Review 10.4 Merged

66207[BUGFIX] Ensure getUniqueId returns unique ids for grid objects

Christian Kuhn CR +2 V +2 Easy +1 −6 updated 10/22/20, 16:17

Commit message

The fluid based page module tried to return a "unique id" for each
"create content element" button using the `getUniqueId` method.
This id however was not unique as it was stored as class property
after the first creation.

This lead to all buttons got the same ID which is according to the spec
https://html.spec.whatwg.org/multipage/dom.html#the-id-attribute not
allowed.

Therefore the `getUniqueId()` method now returns a new "unique id"
on each call.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1