Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
66214[FEATURE] Allow text-track files for videos
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 51
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/66214/51 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/14/66214/51 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 11
- typo3/sysext/core/Classes/Resource/DisplayCondition/TextTrackDisplayCondition.php5new+43 −0
- typo3/sysext/core/Classes/Resource/Rendering/VideoTagRenderer.php18+66 −5
- typo3/sysext/core/Configuration/TCA/sys_file_metadata.php+16 −0
- typo3/sysext/core/Configuration/TCA/sys_file_reference.php5+85 −1
- typo3/sysext/core/Documentation/Changelog/14.2/Feature-92200-AllowTextTrackFilesForVideos.rstnew+77 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf6+42 −0
- typo3/sysext/core/Tests/Functional/Schema/TcaSchemaTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/DisplayCondition/TextTrackDisplayConditionTest.php2new+105 −0
- typo3/sysext/core/Tests/Unit/Resource/Rendering/VideoTagRendererTest.php3+133 −11
- typo3/sysext/core/ext_tables.sql8+5 −0
- typo3/sysext/filemetadata/Configuration/TCA/Overrides/sys_file_metadata.php2+1 −1
Review log 111173
Show 95148 earlier messages
-
Guido Schmechel uploaded patch set 1 10/20/20, 20:39
-
TYPO3com voted on patch set 1 V -1 10/20/20, 20:54 Completed build in 14m 44s on Tue, 20 Oct, 08:54 PM Test Summary: 54 of 73988 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6704
-
Guido Schmechel rebased onto patch set 2 01/02/21, 12:08
-
TYPO3com voted on patch set 2 V -1 01/02/21, 12:18 Completed build in 10m 17s on Sat, 2 Jan, 12:18 PM Test Summary: 18 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8550
-
Guido Schmechel uploaded patch set 3 01/02/21, 14:06
-
Guido Schmechel uploaded patch set 4 01/02/21, 14:10
-
TYPO3com voted on patch set 3 V -1 01/02/21, 14:16 Completed build in 09m 48s on Sat, 2 Jan, 02:16 PM Test Summary: 18 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8552
-
TYPO3com voted on patch set 4 V -1 01/02/21, 14:19 Completed build in 09m 07s on Sat, 2 Jan, 02:19 PM Test Summary: 18 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8553
-
Guido Schmechel commented on patch set 4 01/02/21, 14:20
The approach is now open for discussion. Once we have the right way here, we can add tests and RST. -
Guido Schmechel uploaded patch set 5 01/02/21, 14:20
-
TYPO3com voted on patch set 5 V -1 01/02/21, 14:30 Completed build in 09m 34s on Sat, 2 Jan, 02:30 PM Test Summary: 18 of 32781 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8554
-
Martin Kutschker commented on patch set 5 01/05/21, 17:31
sys_file_reference.php:234Ideally this field should be required for the kind "subtitles" as required by the spec.locallang_tca.xlf:484Maybe it's better to use "Text Tracks" as it is the HTML tag is named fully in the spec. MDN suggests also "Timed Text Tracks" or "Time-based Data". Or a combination "Text Tracks and Time-based Data" 😊ext_tables.sql:276Seems to be very long for a BCP47 tag (in the BE mostly knows as RFC 1766/3066) https://tools.ietf.org/html/bcp47ext_tables.sql:278Seems a bit short for a human readable label. -
Martin Kutschker commented on patch set 5 V -1 CR -1 01/05/21, 17:38
Good start. If you had used the [WIP] prefix you could have avoided my -1 :)VideoTagRenderer.php:155> Call to undefined method TYPO3\CMS\Core\Resource\File::getOriginalFile() This exceptions occurs when I invoke the info item in the list module. -
Guido Schmechel uploaded patch set 6 01/05/21, 22:06
-
TYPO3com voted on patch set 6 V -1 01/05/21, 22:07 Completed build in 40s on Tue, 5 Jan, 10:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8657
-
Guido Schmechel uploaded patch set 7 01/05/21, 22:21
-
TYPO3com voted on patch set 7 V -1 01/05/21, 22:31 Completed build in 09m 50s on Tue, 5 Jan, 10:31 PM Test Summary: 1 of 32798 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8658
-
Guido Schmechel uploaded patch set 8 01/05/21, 22:38
-
Guido Schmechel commented on patch set 8 01/05/21, 22:38
locallang_tca.xlf:484ReplyDoneext_tables.sql:276ReplyDoneext_tables.sql:278ReplyDone -
Guido Schmechel commented on patch set 8 01/05/21, 22:41
VideoTagRenderer.php:155ReplyThanks is fixed. The video is not loaded at the moment, see https://forge.typo3.org/issues/93226sys_file_reference.php:234ReplyHere we would have to integrate an extra class for a condition via eval. It should only be "required" for the value "subtitles". Is this a bit too much logic for a backend field? What do you say? -
TYPO3com voted on patch set 8 V +1 01/05/21, 22:49 Completed build in 10m 52s on Tue, 5 Jan, 10:49 PM Test Summary: 32557 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8659
-
Martin Kutschker commented on patch set 8 01/06/21, 10:34
sys_file_reference.php:234ReplyI wrote ideally because I was unsure how easy that can be implemented. Better to have the feature in and subtitles in the FE than without. After all the enforced requirement is only a "hint" for the editor after all anyone adding subtitles should know what he is doing. -
Martin Kutschker commented on patch set 8 01/06/21, 10:35
sys_file_reference.php:234ReplyAck -
Guido Schmechel uploaded patch set 9 01/06/21, 17:01
-
TYPO3com voted on patch set 9 V -1 01/06/21, 17:02 Completed build in 28s on Wed, 6 Jan, 05:02 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8690
-
Guido Schmechel uploaded patch set 10 01/06/21, 17:02
-
TYPO3com voted on patch set 10 V -1 01/06/21, 17:03 Completed build in 34s on Wed, 6 Jan, 05:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8691
-
Guido Schmechel uploaded patch set 11 01/06/21, 17:52
-
TYPO3com voted on patch set 11 V -1 01/06/21, 17:53 Completed build in 21s on Wed, 6 Jan, 05:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8699
-
Guido Schmechel uploaded patch set 12 01/06/21, 18:09
-
TYPO3com voted on patch set 12 V +1 01/06/21, 18:19 Completed build in 09m 36s on Wed, 6 Jan, 06:19 PM Test Summary: 32567 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8700
-
Guido Schmechel uploaded patch set 13 01/06/21, 21:22
-
Guido Schmechel uploaded patch set 14 01/06/21, 21:26
-
TYPO3com voted on patch set 13 V -1 01/06/21, 21:33 Completed build in 10m 41s on Wed, 6 Jan, 09:33 PM Test Summary: 1 of 32822 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8703
-
TYPO3com voted on patch set 14 V +1 01/06/21, 21:38 Completed build in 11m 46s on Wed, 6 Jan, 09:38 PM Test Summary: 32581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8704
-
Guido Schmechel commented on patch set 14 01/06/21, 21:40
Ready to review Hint: The video and the tracks are not displayed in the backend when clicking on "Information". This bug is dealt with in another ticket. -
TYPO3com voted on patch set 14 V -1 01/06/21, 21:47 Completed build in 11m 19s on Wed, 6 Jan, 09:47 PM Test Summary: 2 of 32822 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8705
-
TYPO3com commented on patch set 14 01/06/21, 22:13 Completed build in 10m 04s on Wed, 6 Jan, 10:13 PM Test Summary: 1 of 32822 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8706
-
TYPO3com voted on patch set 14 V +1 01/07/21, 09:18 Completed build in 09m 59s on Thu, 7 Jan, 09:18 AM Test Summary: 32581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8721
-
Martin Kutschker updated the commit message in patch set 15 01/07/21, 10:15
-
Martin Kutschker commented on patch set 16 01/07/21, 10:28
Published edit on patch set 15. -
TYPO3com voted on patch set 15 V -1 01/07/21, 10:40 Completed build in 21m 13s on Thu, 7 Jan, 10:40 AM Test Summary: 1 of 32822 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8727
-
TYPO3com voted on patch set 16 V +1 01/07/21, 10:45 Completed build in 11m 14s on Thu, 7 Jan, 10:45 AM Test Summary: 32581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8728
-
Martin Kutschker commented on patch set 16 CR -1 01/07/21, 10:50
SubTitleDisplayCondition.php:24Subtitles are only one use case. Please rename to TextTrackDisplayConditionVideoTagRenderer.php:173The spec says "The value of the label attribute, if the attribute is present, must not be the empty string. ". But it may be omitted, so check before putting together the tag.VideoTagRenderer.php:175If the kind is subtitle scrlang must not be empty. If it is do not render the tag.VideoTagRenderer.php:176Is it possible that there is no public URL available? Better get URL first and check if not empty.locallang_tca.xlf:571Please change to "Captions / Audio Description (for the hearing impaired)"locallang_tca.xlf:574Please change to "Video Description (for the visually impaired) -
Guido Schmechel uploaded patch set 17 01/07/21, 13:28
-
TYPO3com voted on patch set 17 V +1 01/07/21, 13:37 Completed build in 09m 40s on Thu, 7 Jan, 01:37 PM Test Summary: 32581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8733
-
Guido Schmechel commented on patch set 17 01/07/21, 13:58
All done, thanks :-) New: Sorting the TCA options (kind) by english label. Does this make sense or would it be better to sort by value as before?SubTitleDisplayCondition.php:24ReplyDoneVideoTagRenderer.php:173ReplyDoneVideoTagRenderer.php:175ReplyDoneVideoTagRenderer.php:176ReplyDonelocallang_tca.xlf:571ReplyDonelocallang_tca.xlf:574ReplyDone -
Martin Kutschker commented on patch set 17 01/08/21, 09:04
Reply
Alphabetical sorting for the default language is ok, but makes not much sense as it will be unsorted for all other languages. For kind to me matter of importance is a better choice. User tracks before script tags. I'd use the order of the spec: substitles, captions, desritopions, chapter, metadata. -
Guido Schmechel commented on patch set 17 01/08/21, 09:40
Do we need the default attribute at the beginning? https://www.w3schools.com/TAgs/att_track_default.asp If so, I would add a simple checkbox and catch it during rendering if someone has selected the checkbox more than once. -
Michael Telgkamp commented on patch set 17 V -1 01/08/21, 14:52
A track with kind="subtitles" and no lang defined still works in the browser (Tested with Firefox and Chrome), so it is confusing it is not rendered although there is no hint in the backend. I think it is hard to determine the required status of the trackLanguage with the TCA settings, but the track-Tag could either be rendered although not fully valid or there should be an informative message that the language setting is required in case the type is "subtitles". It would be nice to also have an option to set a track as default, because in some cases there should be an active text track by default (e.g. sign language videos). -
Martin Kutschker commented on patch set 17 01/08/21, 15:51
Reply
Guido and me have discussed the issue of language being required for "subtitles" and decided to implement it this way as we couldn't find (for now) a way to make it required. Though if you think about it is a bit odd, that language isn't required for the other text tracks. I'm not sure what the intenion of the spec here is. Perhaps they think that only "subtitles" will likely contain a translation assuming the other tracks to be in the page language (or the language of the video tag???). A simple ad-hoc solution is an informative text in the BE that language is required for subtitles. A later patch could try to make it a real requirement in the BE. -
Martin Kutschker commented on patch set 17 01/08/21, 16:04
Reply
The spec groups subtitles and captions as "audio text". So only one of either of these kinds may be default. But at the same time there may be also a description, ie "video text", may be default. "Each media element must have no more than one track element child whose kind attribute is in the Subtitles or Captions state and whose default attribute is specified. Each media element must have no more than one track element child whose kind attribute is in the Descriptions state and whose default attribute is specified." Without further complicating the BE I'd enforce the rules in the FE, so that TYPO3 never renders invalid HTML. If and how we tell the editor about these facts is another issue.Reply
BTW, there are even more restrictions hard to convey in the BE, eg: "The value of the label attribute, if the attribute is present, must not be the empty string. Furthermore, there must not be two track element children of the same media element whose kind attributes are in the same state, whose srclang attributes are both missing or have values that represent the same language, and whose label attributes are again both missing or both have the same value." -
Guido Schmechel uploaded patch set 18 01/08/21, 21:07
-
Guido Schmechel commented on patch set 18 CR -1 01/08/21, 21:08
On it for default setting -
TYPO3com voted on patch set 18 V +1 01/08/21, 21:18 Completed build in 11m 05s on Fri, 8 Jan, 09:18 PM Test Summary: 32583 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8773
-
Martin Kutschker commented on patch set 18 01/09/21, 09:25
Reply
For validations there are two non-exclusive options: a) validition on the server side in, feedback with flash messages b) validation on the client sise in JS, feedback with ??? Perhaps we should ask for the best way in the context of the Core. -
Guido Schmechel uploaded patch set 19 01/09/21, 12:41
-
Guido Schmechel commented on patch set 19 01/09/21, 12:42
Reply
This whole spec is hell to maintain in the backend. Even with the "default" attribute there are x possibilities. My opinion: We should keep it simple here and give the user more responsibility. -
TYPO3com voted on patch set 19 V +1 01/09/21, 12:51 Completed build in 09m 11s on Sat, 9 Jan, 12:51 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8776
-
Martin Kutschker commented on patch set 19 01/09/21, 21:09
Reply
Same here. It's sad that the backend isn't capable enough right now. We should add a proper help text in the BE and possibly a server side validation that uses a flash message to tell the user about broken/unexpected FE output. -
Michael Telgkamp commented on patch set 19 01/11/21, 15:51
Reply
As for the validity of the HTML: also the html validator (which is a reference for me) does not complain if there is no srclang attribute when having a track with kind="subtitles". So I would prefer to do it the way all browsers and the validator accept and do not enforce the srclang to be set. (By the way, the validator complained that there is an invalid no-cookie attribute in the video tag.) Also there should be a description for Editors that the "Track language" is meant to be encoded, because otherwise editors might write "German" or "deutsch" and wonder why only 6 characters are allowed. Additionally, according to https://en.wikipedia.org/wiki/IETF_language_tag and https://www.w3.org/TR/html401/struct/dirlang.html#h-8.1 there are language tags longer than 6 characters (e.g. zh-hakka for Hakka Chinese or en-cockney). Allowing more characters will enlarge the potential of misuse mentioned in the abstract above. -
Benni Mack commented on patch set 19 01/11/21, 16:12
ext_tables.sql:277other lines have a "tab" as indention, the added lines have spaces, care to update? -
Martin Kutschker commented on patch set 19 01/11/21, 16:30
Reply
Spec side, in practice the language attribute will not matter if you have only one track. Then there is no choice for the browser anyway. The clever editor tests the page in a browser when uploading tracks in different languages. I'm fine without the check in the BE. As for the length - without counting - something about 15 chars is a maximum I recall from my memory. -
Guido Schmechel voted on patch set 19 CR -1 01/11/21, 21:06
-
Guido Schmechel uploaded patch set 20 01/16/21, 12:41
-
Guido Schmechel commented on patch set 20 01/16/21, 12:47
ext_tables.sql:277ReplyInterestingly, in my editor (phpStorm) it is indented with tab. Maybe someone can fix this for me in this patch? -
Guido Schmechel commented on patch set 20 01/16/21, 12:50
Reply
I have now gone to 30 characters because of a wikipedia example with "extension" "he-IL-u-ca-hebrew-tz-jeruslm represents Hebrew as spoken in Israel, using the traditional Hebrew calendar, and in the "Asia/Jerusalem" time zone as identified in the tz database." In addition, we safeguard ourselves for later updates. I think it's OK to give a few more signs. Descriptions have been added. Since these are not my strength, please check and change :-) -
TYPO3com voted on patch set 20 V +1 01/16/21, 12:52 Completed build in 10m 33s on Sat, 16 Jan, 12:52 PM Test Summary: 32591 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8876
-
Guido Schmechel uploaded patch set 21 01/17/21, 14:57
-
TYPO3com voted on patch set 21 V +1 01/17/21, 15:07 Completed build in 09m 55s on Sun, 17 Jan, 03:07 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8899
-
Guido Schmechel uploaded patch set 22 01/17/21, 15:18
-
TYPO3com voted on patch set 22 V -1 01/17/21, 15:28 Completed build in 09m 43s on Sun, 17 Jan, 03:28 PM Test Summary: 30045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8900
-
TYPO3com commented on patch set 22 01/17/21, 15:42 Completed build in 10m 30s on Sun, 17 Jan, 03:41 PM Test Summary: 8 of 32852 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8901
-
Guido Schmechel commented on patch set 22 01/17/21, 15:52
Here is the proposal based on the extension filemetadata. -1 is set because Bamboo has dropped out again. Further adjustments - track_type to track_kind to take over the name of the html spec - SQL indentations corrected To discuss If we remove the query on "language", we could even set subtitles without EXT:filemetadata. Of course, without any real options. This would then only be type subtitles + own label. -
TYPO3com voted on patch set 22 V +1 01/17/21, 16:18 Completed build in 10m 47s on Sun, 17 Jan, 04:18 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8902
-
Martin Kutschker uploaded patch set 23 03/06/21, 16:34
-
TYPO3com voted on patch set 23 V -1 03/06/21, 16:34 Completed build in 14s on Sat, 6 Mar, 04:34 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9885
-
core-ci voted on patch set 23 V -1 03/06/21, 16:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1224
-
Guido Schmechel uploaded patch set 24 03/07/21, 08:31
-
TYPO3com voted on patch set 24 V -1 03/07/21, 08:38 Completed build in 07m 06s on Sun, 7 Mar, 08:38 AM Test Summary: 2 of 33002 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9895
-
core-ci voted on patch set 24 V -1 03/07/21, 08:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1237
-
Guido Schmechel commented on patch set 24 03/07/21, 10:46
Small fix for class using and SQL query. FE is fine, but tests are failing because of the the sql query. -
Martin Kutschker commented on patch set 24 03/07/21, 17:41
Reply
AckReply
I've changed the order as suggested by myself.ext_tables.sql:277ReplyDone -
Martin Kutschker commented on patch set 24 03/07/21, 17:43
Reply
Thank you for taking care. The "rx" is a stupid blunder (leftover of a test run). The additional RestrictionContainer class is another matter: should it be used in the FE? Some other parts in the core add it. -
Martin Kutschker uploaded patch set 25 03/07/21, 18:20
-
TYPO3com voted on patch set 25 V -1 03/07/21, 18:27 Completed build in 06m 25s on Sun, 7 Mar, 06:27 PM Test Summary: 2 of 33002 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9904
-
core-ci voted on patch set 25 V -1 03/07/21, 18:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1246
-
Guido Schmechel commented on patch set 25 03/07/21, 19:20
Reply
Good point with the restriction. New restrictions compared to the standard: - FrontendWorkspaceRestriction::class - FrontendGroupRestriction::class IMO: Both cases cannot be considered for files. So we could remove the restriction and the missing environment function. Check: DebugUtility::debug($queryBuilder->getRestrictions()); -
Martin Kutschker commented on patch set 25 03/07/21, 19:40
Reply
In theory an integrator could impose restrictions on the files by configuring the TCA. If this is a valid use case or not I don't know. Someone with the big picture of resctrions in mind may decide. It ain't me :) -
Martin Kutschker uploaded patch set 26 03/07/21, 19:46
-
TYPO3com voted on patch set 26 V -1 03/07/21, 19:53 Completed build in 06m 30s on Sun, 7 Mar, 07:53 PM Test Summary: 2 of 33002 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9905
-
core-ci voted on patch set 26 V -1 03/07/21, 19:56 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1247
-
Martin Kutschker uploaded patch set 27 03/15/21, 19:10
-
TYPO3com voted on patch set 27 V +1 03/15/21, 19:17 Completed build in 07m 27s on Mon, 15 Mar, 07:17 PM Test Summary: 32715 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10144
-
core-ci voted on patch set 27 V +1 03/15/21, 19:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1561
-
Guido Schmechel uploaded patch set 28 03/20/21, 10:16
-
TYPO3com voted on patch set 28 V +1 03/20/21, 10:23 Completed build in 06m 38s on Sat, 20 Mar, 10:23 AM Test Summary: 32921 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10248
-
core-ci voted on patch set 28 V +1 03/20/21, 10:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1709
-
Markus Klein commented on patch set 28 06/14/21, 09:14
Without having tested it, just a question that comes to my mind: You introduce a relation between files here. Does that work out correctly with translations? (files/-references are always a bit special in this area, so that's why I'm asking) -
Guido Schmechel commented on patch set 28 07/15/21, 21:19
Reply
Yes, not quite trivial. The Video Related Files (VTT) are only displayed in the file list on the MP4. Some background: The maintenance of VTT files should not overload other areas and if you have a VTT translation in other languages, it does not hurt to display it everywhere. For more flexibility we would certainly need a more modern TYPO3 backend ;-) Example: I add a DE and FR VTT file there. If I now create an english page / content element and work there with the MP4, both VTT files (DE, FR) are read out. Note: These do not necessarily have to be VTT files with translations! If I make a Danish translation from the english page and MP4 reference, DE and FR continue to be offered as subtitles from the original file. If you want to separate the subtitles here, e.g. EN displays DE / FR and DK should also read out a DK VTT file, you must create a copy here. Does that perhaps already answer your question? -
Guido Schmechel commented on patch set 28 07/15/21, 21:21
Reply
If you want to talk about it via Slack, we can do that. It might help with the approach and what we had in mind. -
Guido Schmechel rebased onto patch set 29 08/13/21, 17:12
-
core-ci voted on patch set 29 V -1 08/13/21, 17:40 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15004
-
Guido Schmechel uploaded patch set 30 08/14/21, 15:39
-
core-ci voted on patch set 30 V -1 08/14/21, 15:42 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15089
-
Guido Schmechel uploaded patch set 31 08/14/21, 16:03
-
core-ci voted on patch set 31 V +1 08/14/21, 16:26 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15096
-
Markus Klein commented on patch set 31 08/16/21, 11:26
I read your comment, but I still need some time to think about this in more detail. This may take me some days. -
Markus Klein commented on patch set 31 09/06/21, 09:19
Reply Unresolved
Okay, I thought about this more carefully now. I was actually caught in the "language funnel" because VTT is about translations, but actually we do not have translations at all here, we simply have side-car files. This is actually a generic concept, which could help a lot also in other domains, consider xmp, video-thumb, etc for instance. So what we really need is a support for side-car files in FAL. Those might themselves be translatable again (think of localized video thumbnails). -
Benni Mack wrote 11/29/21, 10:09
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 32 11/29/21, 13:26
-
core-ci voted on patch set 32 V +1 11/29/21, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20029
-
Oliver Klee commented on patch set 32 07/14/23, 11:38
Guido, is this change still relevant? If so, would you be willing to rebase and update it? -
Guido Schmechel commented on patch set 32 07/14/23, 12:23
Reply
The interest is definitely there. However, this was about fundamental decisions regarding FAL and side references and then the topic stalled for the time being. Probably more a topic for a code sprint? -
Guido Schmechel uploaded patch set 33
V +108/05/23, 23:06 -
core-ci voted on patch set 33 V -1 08/05/23, 23:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45131
-
Guido Schmechel uploaded patch set 34
V -108/05/23, 23:40 -
core-ci voted on patch set 34 V -1 08/05/23, 23:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45132
-
Guido Schmechel uploaded patch set 35
V -108/06/23, 09:48 -
core-ci voted on patch set 35 V -1 08/06/23, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45142
-
Guido Schmechel uploaded patch set 36
V -108/06/23, 12:14 -
Guido Schmechel uploaded patch set 37 08/06/23, 12:21
-
core-ci voted on patch set 36 V -1 08/06/23, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45146
-
core-ci voted on patch set 37 V -1 08/06/23, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45147
-
Guido Schmechel uploaded patch set 38
V -108/06/23, 12:44 -
core-ci voted on patch set 38 V +1 08/06/23, 12:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45149
-
Guido Schmechel commented on patch set 38 08/06/23, 13:04
The patch is now ready for v13. Feedback after all the changes is welcome. Of course also from an editorial point of view. Follow-up patch: If the base is right, the audio tag will be followed as well. Possible follow-up patch: Automated linking of files and VTT would be great, but finding the criteria is certainly difficult. Maybe we add an event in the VideoTagRenderer to intervene in the generation? There is much to discuss :-) -
Chris Müller uploaded patch set 39
V +108/07/23, 07:33 -
core-ci voted on patch set 39 V +1 08/07/23, 07:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45166
-
Simon Schaufelberger commented on patch set 39 CR -1 08/08/23, 17:22
TextTrackDisplayCondition.php:34I would prefer an early return here which means switch the logic and return false here andthen move the code out of the if to the end of the method.VideoTagRenderer.php:40can be dropped as it is a duplicate of the native return typeVideoTagRenderer.php:153can be droppedVideoTagRenderer.php:201can be droppedFeature-92200-AllowTextTrackFilesForVideos.rst:5the line should have the same length as the titlesys_file_metadata.php:130there are 2 white spaces before "tracks" -
Guido Schmechel uploaded patch set 40
CR -1V +108/08/23, 20:32 -
core-ci voted on patch set 40 V +1 08/08/23, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45262
-
Guido Schmechel commented on patch set 40 08/08/23, 20:48
Reply
DoneReply
DoneReply
DoneTextTrackDisplayCondition.php:34ReplyDoneVideoTagRenderer.php:40ReplyDoneVideoTagRenderer.php:153ReplyDoneVideoTagRenderer.php:201ReplyDoneFeature-92200-AllowTextTrackFilesForVideos.rst:5ReplyDonesys_file_metadata.php:130ReplyDone -
Simon Schaufelberger commented on patch set 40 08/09/23, 03:30
VideoTagRenderer.php:201Replythere are a few more which can be dropped as well. -
Simon Schaufelberger commented on patch set 40 CR -1 08/09/23, 03:32
VideoTagRenderer.php:40hereTextTrackDisplayConditionTest.php:52here -
Guido Schmechel uploaded patch set 41
CR -1V +108/09/23, 19:00 -
core-ci voted on patch set 41 V +1 08/09/23, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45287
-
Guido Schmechel commented on patch set 41 08/09/23, 19:23
Thanks! :-)VideoTagRenderer.php:40ReplyDoneTextTrackDisplayConditionTest.php:52ReplyDone -
Guido Schmechel commented on patch set 41 08/09/23, 19:34
VideoTagRenderer.php:201ReplyDone -
Benni Mack commented on patch set 41 08/10/23, 12:38
Tried the patch, works really fine. Questions for me: * Should we move the logic into EXT:filemetadata? * Can we somehow define a new palette for sys_file_metadata which is used when referencing text-track files instead of adding this to the default palette with the ? Don't know if this is possible. Maybe we could avoid using the DisplayCondition then... * Would you rather have the relation at sys_file level than on sys_file_metadata level (which can be translated)? Just thinking out loud here... -
Guido Schmechel commented on patch set 41 08/10/23, 15:23
On it :-)Reply
Thanks for your feedback! I'll try out a little bit this weekend. I think my main problem then was that VTT files are also assigned to \TYPO3\CMS\Core\Resource\File::FILETYPE_TEXT. Hence then the condition. If we lift the relationship to the sys_file, it would have the advantage that things would be directly in EXT:core and the dependency to the EXT:sys_file_metadata could be removed. The question is whether such side-files are rather metadata or not. I don't think we have that case in core so far? -
Benni Mack commented on patch set 41 08/10/23, 16:02
Reply
My main topic regarding sys_file vs. sys_file_metadata is: Is the usecase that is attached to a file (let's say: I have a video that has metadata that is translated, but the VTT relation information does not need to be translated as they stay the same for the same file?) -
Guido Schmechel commented on patch set 41 08/10/23, 18:34
Reply Unresolved
I don't think the VTT files need to be translated. Let's say I have a customer with DE and EN translation. And the customer now wants to offer the video with FR subtitles. Then a FR TYPO3 language would also have to be created for the metadata to translate the VTT if I understand you correctly? I would prefer the free way without any core translation option. -
Benni Mack commented on patch set 41 09/14/23, 12:09
So, I actually use this in production for a project, and I had a few remarks regarding the general implementation: * "srcLang" -> we could actually derive this from sys_file_metadata.content_language or are there reasons for not using it? * "default" -> based on sys_file_metadata, the default could be different based on the actual output language. Does this make sense to use this option at all? -
Guido Schmechel commented on patch set 41 09/15/23, 19:45
Reply
Nice to hear that someone is testing :-) "default" -> based on sys_file_metadata, the default could be different based on the actual output language. Does this make sense to use this option at all? I don't know which field you mean specifically, but I had deliberately created a new field in order to be able to set descriptions and more precisely. In addition: Language of the track text data. It must be a valid BCP 47 language tag. content_language might then be "English", whereas here we need "en". For me, the goal is to be able to give the user a free choice. For example, you have English, French and Spanish as subtitles and your website is in Danish. Then I want English to be the default, even though there are no translated subtitles for my website language. Let's also discuss via Slack if there are still questions and we'll record the results here. -
Oliver Klee wrote 10/08/23, 13:24
Removed cc Oliver Klee. -
Guido Schmechel uploaded patch set 42
V +110/27/23, 21:56 -
core-ci voted on patch set 42 V -1 10/27/23, 22:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48317
-
Guido Schmechel uploaded patch set 43
V -110/28/23, 08:26 -
core-ci voted on patch set 43 V +1 10/28/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/48321
-
Guido Schmechel rebased onto patch set 44
V +111/30/23, 13:01 -
core-ci voted on patch set 44 V +1 11/30/23, 13:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/50166
-
Benni Mack commented on patch set 44 01/23/24, 21:33
TextTrackDisplayCondition.php:41if we use canRender() we do not need the new method getPossibleMimetypes() - right? -
Stefan Bürk commented on patch set 44 01/24/24, 00:09
The addedVideoTagRendererTest.php:187yeah, mock party - I'd suggest to realize this test as functional test instead, so we really test all parts. and not test the tag rendering on a lot of assumptions and mockings. the mock setup for the test is scary huge -
Chris Müller uploaded patch set 45
V +101/30/24, 19:01 -
core-ci voted on patch set 45 V +1 01/30/24, 19:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52510
-
Simon Schaufelberger uploaded patch set 46
V +104/21/24, 20:53 -
core-ci voted on patch set 46 V +1 04/21/24, 20:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56443
-
Simon Schaufelberger commented on patch set 45 04/21/24, 21:01
TextTrackDisplayCondition.php:41ReplyDoneVideoTagRendererTest.php:187ReplyI agree. What would you suggest as an entry point? All other Renderer are all Unit Tests. -
Simon Schaufelberger uploaded patch set 47
V +104/21/24, 21:01 -
core-ci voted on patch set 47 V +1 04/21/24, 21:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/56444
-
Stefan Bürk commented on patch set 47 04/21/24, 23:15
VideoTagRendererTest.php:187Reply UnresolvedProvide files to test instance from fixtures folder, create a csv to create database records for the files (fal). And then use the tag render real without mocking the files/data stuffs but let it retrieved from files/database and check the output. For example, see ImageViewHelper functional test and others testing stuff related to database and FAL. Or frontend content object rendering tests. There should be many example to start with. If that makes issues finish a full frontend setup (adding pages + content element containing which uses that tag renderer and do a frontend subrequest and check the response body content for the tag. -
Guido Schmechel uploaded patch set 48
V +101/19/25, 15:05 -
Guido Schmechel uploaded patch set 49 01/19/25, 15:07
-
core-ci voted on patch set 48 V -1 01/19/25, 15:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72679
-
core-ci voted on patch set 49 V -1 01/19/25, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72680
-
Guido Schmechel uploaded patch set 50
V -101/19/25, 15:59 -
core-ci voted on patch set 50 V +1 01/19/25, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72684
-
Guido Schmechel commented on patch set 50 CR -1 01/19/25, 16:07
Just a rebase. Conversion of the tests is still open -
Simon Schaufelberger uploaded patch set 51
CR -1V +103/07/26, 19:50 -
core-ci voted on patch set 51 V -1 03/07/26, 20:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97550
-
Georg Ringer commented on patch set 51 03/10/26, 04:26
TextTrackDisplayCondition.php:1UnresolvedI would call that IsVideoFileCondition. there is no check for trackssys_file_reference.php:143Unresolveddo we really need that in sys_file_reference? I would keep that in sys_file_metadata only as I can't imagine a situation where the data is different for same videos?ext_tables.sql:128Unresolveddo we really need that? -
Benni Mack wrote 04/21/26, 14:51
Removed cc Benni Mack.