Review main Merged

66232[BUGFIX] Fix FAL meta data extraction priorities

Helmut Hummel CR +2 V +2 Hard +221 −44 updated 11/06/22, 13:21

Commit message

File meta data extractors have to provide an execution priority and a
data priority. The execution priority, which was previously ignored, is
now respected and extractors are ordered accordingly in
ExtractorRegistry.

Extractors with the same data priority can now provide data, while the
data was overwritten previously.

ExtractorRegistry::getExtractorsWithDriverSupport now returns a flat
array of extractors again, not a nested one like introduced in #64942,
just like annotated.

Because this fix might change the order of the execution of extractors,
it can be considered slightly breaking, thus TYPO3 11.5 is not targeted.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 2744

Show 1319 earlier messages
  1. Helmut Hummel uploaded patch set 1 10/21/20, 13:11

  2. TYPO3com voted on patch set 1 V -1 10/21/20, 13:32 Completed build in 17m 59s on Wed, 21 Oct, 01:32 PM Test Summary: 1 of 74003 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6735

  3. Markus Klein commented on patch set 1 10/21/20, 13:39

    ExtractorRegistry.php:99

    a = empty($extractorObject->getDriverRestrictions()) b = in_array($driverType, $extractorObject->getDriverRestrictions(), true) The condition changed. an extractor was returned if: a || b now we keep it in the array if: !a && b Not sure if this is intended. From the description of the function, I would say "yes, correct NOW. unrestricted drivers are excluded".
  4. Helmut Hummel rebased onto patch set 2 10/26/20, 12:27

  5. Helmut Hummel commented on patch set 2 CR -2 10/26/20, 12:38

    ExtractorRegistry.php:99 Reply

    Good catch! Not intentional.
  6. TYPO3com voted on patch set 2 V +1 10/26/20, 12:39 Completed build in 12m 14s on Mon, 26 Oct, 12:39 PM Test Summary: 73590 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6886

  7. Helmut Hummel uploaded patch set 3 10/26/20, 12:55

  8. Helmut Hummel voted on patch set 2 CR 0 10/26/20, 12:56

  9. Helmut Hummel commented on patch set 3 10/26/20, 12:56

    ExtractorRegistry.php:99 Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 10/26/20, 13:08 Completed build in 12m 16s on Mon, 26 Oct, 01:08 PM Test Summary: 73596 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6890

  11. Benni Mack rebased onto patch set 4 09/01/21, 07:17

  12. core-ci voted on patch set 4 V +1 09/01/21, 07:32 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15982

  13. Helmut Hummel updated the commit message in patch set 5 09/01/21, 08:52

  14. core-ci voted on patch set 5 V +1 09/01/21, 09:06 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15991

  15. Benni Mack wrote 11/29/21, 10:10

    Change destination moved from master to main
  16. Benni Mack updated the commit message in patch set 6 11/29/21, 13:25

  17. core-ci voted on patch set 6 V +1 11/29/21, 15:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20023

  18. Helmut Hummel uploaded patch set 7 11/29/21, 15:57

  19. Simon Gilli updated the commit message in patch set 8 11/29/21, 16:00

  1. core-ci voted on patch set 8 V -1 11/29/21, 18:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20147

  2. core-ci voted on patch set 7 V -1 11/29/21, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20146

  3. Simon Gilli commented on patch set 9 12/02/21, 23:46

    Published edit on patch set 8.
  4. core-ci voted on patch set 9 V +1 12/03/21, 00:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20449

  5. Simon Schaufelberger uploaded patch set 10 03/22/22, 22:34

  6. Simon Schaufelberger commented on patch set 10 03/22/22, 22:36

    Rebased, no additional changes
  7. core-ci voted on patch set 10 V -1 03/22/22, 22:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/25059

  8. Henning Liebe rebased onto patch set 11 06/24/22, 13:46

  9. Henning Liebe commented on patch set 11 06/24/22, 13:47

    rebase only
  10. core-ci voted on patch set 11 V -1 06/24/22, 13:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28390

  11. Oliver Klee commented on patch set 11 CR -1 06/24/22, 13:57

    On it - we'll need to regenerate the PHPStan baseline.
  12. Oliver Klee uploaded patch set 12 06/24/22, 14:00

  13. core-ci voted on patch set 12 V -1 06/24/22, 14:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28392

  14. core-ci commented on patch set 12 06/24/22, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28392

  15. core-ci commented on patch set 12 06/24/22, 14:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28392

  16. core-ci commented on patch set 12 06/24/22, 14:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28392

  17. core-ci voted on patch set 12 V +1 06/24/22, 16:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/28392

  18. Markus Klein voted on patch set 12 CR +1 06/24/22, 18:07

  19. Simon Schaufelberger wrote 06/24/22, 19:17

    Removed cc Simon Schaufelberger.
  20. Benni Mack uploaded patch set 13 11/05/22, 20:38

  21. Benni Mack voted on patch set 13 CR +1 11/05/22, 20:41

  22. core-ci voted on patch set 13 V +1 11/05/22, 20:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33151

  23. Markus Klein voted on patch set 13 V +1 CR +1 11/06/22, 09:30

  24. Benni Mack voted on patch set 13 V +2 CR +2 11/06/22, 13:21

  25. Benni Mack merged patch set 14 11/06/22, 13:21