Review main Merged

66233[BUGFIX] Use button tag for modal buttons in InlineControlContainer

Olaf Schmidt-Wischhöfer CR +2 V +2 Normal +37 −40 updated 01/28/21, 08:11

Commit message

Instead of <a href="#" ...> or <span ...>, a <button> tag is used for
inline relations to enable proper keyboard navigation.

* rename variable and protected method names from "link" to "button"
* remove unsed $objectPrefix argument from getLevelInteractionLink
  (now ...Button)

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1