Review main Merged

66237[TASK] Use correct html element for actions in RecordList

Georg Ringer CR +2 V +2 Hard +188 −123 updated 06/21/21, 12:48

Commit message

Differentiate between tags 'a' and 'button' in the record list.
An a-tag opens a page, a button triggers an action.

Additionally the change includes 3 accessibility related issues:

Implement browser "tooltips" (ie title attributes) on a-tags
and button-tags as Bootstrap tooltips.

Add aria-haspopup="dialog" on buttons that open a Bootstrap modal
which are implemented as ARIA role dialog.

Remove attribute role="group" from elements without accessible name.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5