Review main Merged

66241[BUGFIX] Make sure external link checks time out

Sybille Peters CR +2 V +2 Normal +172 −0 updated 11/20/20, 15:57

Commit message

The HTTP requests for checking external links did not have a
timeout. The timeout from Global Configuration was used
which is set to 0 (not timeout) by default.

This could cause the link checking to run
indefinitely and scheduler tasks to never terminate.

Usually, there is a connect timeout, a read timeout
and a total timeout. We set the total timeout and make
this configurable via page TSconfig.

If this is not set via TSconfig, it will default to the
value set in $GLOBALS['TYPO3_CONF_VARS']['HTTP']['timeout'].

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5