Review main Abandoned

66255[BUGFIX] Fix value of multiple checkboxes in site configuration

Chris Müller CR 0 V 0 Easy +25 −2 updated 11/05/21, 15:33

Commit message

When extending the site configuration with an extension and
use multiple (activated) checkboxes, only the first checkbox is
saved as activated. This is due the converting of a check type
always to a boolean. It is corrected with considering the
renderType.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 68

  1. Chris Müller uploaded patch set 1 10/22/20, 16:22

  2. TYPO3com voted on patch set 1 V +1 10/22/20, 16:40 Completed build in 13m 09s on Thu, 22 Oct, 04:40 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6810

  3. Benni Mack voted on patch set 1 CR +1 11/04/21, 12:54

  4. Oli Bartsch rebased onto patch set 2 11/04/21, 16:29

  5. Oli Bartsch commented on patch set 2 11/04/21, 16:30

    SiteConfigurationController.php:386

    Needs to be adjusted as well.

    SiteConfigurationController.php:460

    Using multi checkboxes (items) should IMO not depend on the renderType. At least "checkboxToggle" can be used this way, too.
  6. core-ci voted on patch set 2 V +1 11/04/21, 16:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18912

  7. Chris Müller commented on patch set 2 V -1 11/05/21, 15:16

    Would apply to abandon the patch after futher investigation if nothing speaks against it.

    SiteConfigurationController.php:386 Reply Unresolved

    New IRRE elements cannot be added by extensions. So core has to use it but it does not. So a check is not needed for now.

    SiteConfigurationController.php:460 Reply Unresolved

    I did this intentially back then, because a default check item can have multiple checkboxes (which are stored in a bitset). The two render types have only one checkbox (according to the docs). However, I tried now multiple toggles out, which work correctly (also stored in a bitset). So I assume, the patch (which I needed back then in an extension, but use another solution now) makes no sense anymore, as the bitset my be important.
  8. Benni Mack abandoned the change 11/05/21, 15:33

    abandoned as requested