Review main Merged

66256[BUGFIX] Fix value of multiple select choices in site configuration

Chris Müller CR +2 V +2 Easy +7 −1 updated 03/29/21, 12:35

Commit message

When extending the site configuration with an extension and
use a select box with multiple choices (selectSingleBox, selectCheckBox,
selectMultipleSideBySide), the activated options are stored
as an array in the config.yaml file. But to show the activated
items in the form again correctly they must be stored as in
comma-separated list.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1114

  1. Chris Müller uploaded patch set 1 10/22/20, 17:15

  2. TYPO3com voted on patch set 1 V +1 10/22/20, 17:27 Completed build in 12m 25s on Thu, 22 Oct, 05:27 PM Test Summary: 73458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6811

  3. Benni Mack voted on patch set 1 V +1 CR +1 03/22/21, 19:09

  4. Christian Kuhn voted on patch set 1 CR +1 03/24/21, 20:56

  5. Christian Kuhn rebased onto patch set 2 03/26/21, 10:10

  6. TYPO3com voted on patch set 2 V +1 03/26/21, 10:17 Completed build in 07m 12s on Fri, 26 Mar, 10:17 AM Test Summary: 33239 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10358

  7. core-ci voted on patch set 2 V +1 03/26/21, 10:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1848

  8. Christian Kuhn voted on patch set 2 CR +1 03/26/21, 10:23

  9. Richard Haeser voted on patch set 2 V +1 CR +1 03/29/21, 12:11

  10. Richard Haeser commented on patch set 2 V 0 CR 0 03/29/21, 12:16

    Need to check something first
  11. Richard Haeser commented on patch set 2 V +1 CR +1 03/29/21, 12:33

    I was in doubt because in frontend the value of the setting is also changed from array to string. So if someone does not care about the UI of the site configuration, but had the TCA to extend it, this is kind of a breaking change. As those types of fields needs this kind of value, I think it is ok to do this and to backport it to v10 as well. I guess not that many people will have this kind of configuration anyways as the docs are stating that just simple TCA is working.
  12. Christian Kuhn voted on patch set 2 V +1 03/29/21, 12:34

  13. Richard Haeser voted on patch set 2 V +2 CR +2 03/29/21, 12:35

  14. Richard Haeser merged patch set 3 03/29/21, 12:35