Review main Merged

66316[TASK] Use Symfony Routing for Backend Routing

Benni Mack CR +2 V +2 Hard +142 −168 updated 11/01/20, 18:24

Commit message

This is a pre-cursor for enhancing Backend Routing in general.

This change implements Symfony Routing for Backend
Routes (currently based on the "route" GET/POST argument)
internally to make use of their compiled routes later-on.

This was previously done in a simplified version where only
the path was checked against, and most Symfony features
were not in use, which we still don't use yet, but more can now
be added.

When Backend Routing was added in TYPO3 v7, the API
was heavily influenced by Symfony but we did not have
a lot of experience yet, which we benefitted in TYPO3 v9+
for Frontend Routing.

With this experience (and with PSR-15) we can gradually
move to a more streamlined and faster API.

The proposed solution still works as expected with &route
GET parameters, but opens up the door for flexible Route arguments.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9