Review main Merged

66324[TASK] Create TER remote instances in symfony service factory

Benjamin Franzke CR +2 V +2 Easy +2 −25 updated 10/27/20, 20:22

Commit message

The remotes are not lazy loaded, therefore there is no need to
inject the container instance into RemoteRegistry.

We can pass the remote instances directly into the
registerRemote method, that has the slight benefit
of avoiding roundtrips and the symfony service defintions
can be inlined/optimized (the remote instances are
created withing the generated RemoteRegistry factory).

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2