Review main Merged

66353[BUGFIX] Use default page id for fetching a site in SlugService

Oli Bartsch CR +2 V +2 Normal +102 −1 updated 10/30/20, 12:32

Commit message

The rebuildSlugsForSlugChange function of SlugService updates
slugs of sub pages and also creates redirects for them, after
changing the slug of their parent page. This process requires
to fetch the corresponding site configuration.

In cases like changing the slug of a localized root page
this throws a SiteNotFoundException, because the site is
always mapped to the default page id which can not be
determined for localized root pages because their pid is 0.

It's therefore necessary to always use the default page
id for fetching the site through SiteFinder.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3