Review main Merged

66373[FEATURE] Add button to create sys_note records directly in modules

Oli Bartsch CR +2 V +2 Normal +185 −0 updated 11/20/20, 20:51

Commit message

System notes are being displayed in various modules.
Previously one however had to always switch to the list
module to add such note.

Therefore, a new button is added to the button bar of the
page, list and info module which allows to directly create
a new sys_note record for the current page. The new button
can be disabled via page TSconfig.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1114

  1. Oli Bartsch uploaded patch set 1 11/02/20, 12:16

  2. TYPO3com voted on patch set 1 V +1 11/02/20, 12:28 Completed build in 12m 02s on Mon, 2 Nov, 12:28 PM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7070

  3. Georg Ringer commented on patch set 1 11/03/20, 06:17

    2 things: - I don't see a check if the user is allowed to create such records? - While I like the specific button, I don't like having now 2 options. what about making that non configurable and remove the record from newrecord controller?
  4. Oli Bartsch uploaded patch set 2 11/03/20, 09:58

  5. Oli Bartsch commented on patch set 2 11/03/20, 10:07

    > Patch Set 1: > > 2 things: > - I don't see a check if the user is allowed to create such records? > - While I like the specific button, I don't like having now 2 options. what about making that non configurable and remove the record from newrecord controller? Thanks for the feedback. The permission checks are now implemented. I think the option should stay in the new record controller as it's the central place to create records of any kind. It's the same for all other types like pages, tt_content, be_users, and so on. You can create such records at various places sometimes even in dedicated modules. But you still can create all those records via new record controller. I'm not a fan of introducing a special case for sys_note now as this IMO just promotes inconsistency.
  6. TYPO3com voted on patch set 2 V +1 11/03/20, 10:10 Completed build in 11m 57s on Tue, 3 Nov, 10:10 AM Test Summary: 73569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7084

  7. Christian Kuhn commented on patch set 2 11/20/20, 17:10

    ButtonBarHook.php:138

    since we are in backend context, rendering buttons here, there *must* be a request object. imho no point to allow null return here.

    ButtonBarHook.php:143

    since we are in backend context there *must* be a backend user object. imho no point to allow null return here.
  8. Christian Kuhn voted on patch set 2 CR -1 11/20/20, 17:10

  9. Oli Bartsch uploaded patch set 3 11/20/20, 17:49

  10. Oli Bartsch commented on patch set 3 11/20/20, 17:50

    ButtonBarHook.php:138 Reply

    Done

    ButtonBarHook.php:143 Reply

    Done
  11. TYPO3com voted on patch set 3 V +1 11/20/20, 18:00 Completed build in 10m 45s on Fri, 20 Nov, 06:00 PM Test Summary: 32391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7492

  12. Georg Ringer voted on patch set 3 V +1 CR +1 11/20/20, 19:42

  13. Christian Kuhn voted on patch set 3 V +2 CR +2 11/20/20, 20:51

  14. Christian Kuhn merged patch set 4 11/20/20, 20:51