Review main Merged

66651[BUGFIX] Check only type-relevant fields in linkvalidator

Sybille Peters CR +2 V +2 Normal +65 −8 updated 09/23/26, 13:15

Commit message

Linkvalidator checks configured fields for broken links, but not all
fields are relevant for every record type. For example, tt_content
records with CType="div" do not use the bodytext field: it is not
shown in the backend form and not rendered in the frontend.

Previously, linkvalidator still checked such fields, reporting broken
links that editors cannot fix, since the field is not editable for
that CType. Opening the edit form from the report then shows an
incomplete form without the reported field.

This uses VisibleSchemaFieldsCollector to determine which fields are
actually part of the record's type (e.g. based on TCA "types"
configuration) and visible to the current backend user. Fields that
are not part of the resolved subschema are now skipped.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 4978

Show 3153 earlier messages
  1. Sybille Peters uploaded patch set 1 11/16/20, 18:48

  2. Sybille Peters uploaded patch set 2 11/16/20, 18:50

  3. Sybille Peters marked it work in progress 11/16/20, 18:51

  4. TYPO3com voted on patch set 1 V +1 11/16/20, 19:00 Completed build in 11m 19s on Mon, 16 Nov, 07:00 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7362

  5. TYPO3com voted on patch set 2 V +1 11/16/20, 19:06 Completed build in 15m 55s on Mon, 16 Nov, 07:06 PM Test Summary: 73695 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7364

  6. Sybille Peters uploaded patch set 3 11/22/20, 18:57

  7. Sybille Peters commented on patch set 3 11/22/20, 19:00

    This change is ready for review.
  8. TYPO3com voted on patch set 3 V -1 11/22/20, 19:08 Completed build in 10m 52s on Sun, 22 Nov, 07:08 PM Test Summary: 32393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7509

  9. Sybille Peters wrote 11/24/20, 18:33

    Topic set to Linkvalidator
  10. Sybille Peters rebased onto patch set 4 11/24/20, 18:33

  11. TYPO3com voted on patch set 4 V -1 11/24/20, 18:45 Completed build in 11m 40s on Tue, 24 Nov, 06:45 PM Test Summary: 32393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7557

  12. TYPO3com commented on patch set 4 11/24/20, 18:48 Completed build in 14m 56s on Tue, 24 Nov, 06:48 PM Test Summary: 32393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7558

  13. Sybille Peters uploaded patch set 5 11/24/20, 19:04

  14. TYPO3com voted on patch set 5 V +1 11/24/20, 19:15 Completed build in 11m 16s on Tue, 24 Nov, 07:15 PM Test Summary: 32393 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7560

  15. Sybille Peters uploaded patch set 6 11/26/20, 13:33

  16. TYPO3com voted on patch set 6 V +1 11/26/20, 13:50 Completed build in 12m 14s on Thu, 26 Nov, 01:50 PM Test Summary: 32396 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7599

  17. Sybille Peters uploaded patch set 7 11/26/20, 19:21

  18. Sybille Peters uploaded patch set 8 11/26/20, 19:22

  19. TYPO3com voted on patch set 7 V -1 11/26/20, 19:32 Completed build in 10m 48s on Thu, 26 Nov, 07:32 PM Test Summary: 114 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7616

  20. TYPO3com voted on patch set 8 V -1 11/26/20, 19:35 Completed build in 11m 44s on Thu, 26 Nov, 07:35 PM Test Summary: 114 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7617

  21. Sybille Peters updated the commit message in patch set 9 11/26/20, 19:41

  22. TYPO3com voted on patch set 9 V -1 11/26/20, 19:55 Completed build in 13m 38s on Thu, 26 Nov, 07:55 PM Test Summary: 114 of 32635 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7619

  23. Sybille Peters uploaded patch set 10 11/30/20, 11:15

  24. TYPO3com voted on patch set 10 V -1 11/30/20, 11:15 Completed build in 30s on Mon, 30 Nov, 11:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7692

  25. Sybille Peters uploaded patch set 11 11/30/20, 11:33

  26. TYPO3com voted on patch set 11 V +1 11/30/20, 11:44 Completed build in 11m 36s on Mon, 30 Nov, 11:44 AM Test Summary: 32407 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7693

  27. Sybille Peters commented on patch set 11 12/02/20, 09:06

    Lolli, can you take a look? It was not so easy to figure out which data providers to use. I considered using TcaDatabaseRecord, but this checks a lot, including permissions and I think permissions by user should not be done on checking, this is already done when the report is generated and the broken links are displayed. To check the type, some more providers are needed. Current solution works, but I may have missed some edge cases.
  28. Benni Mack commented on patch set 11 11/04/21, 11:11

  29. Sybille Peters commented on patch set 11 11/04/21, 12:20

    Reply

    These are 2 different things: The other patch applies a restriction to the database to check if fields is editable via permissions (for editor). For this patch, the permission is irrelevant - it should be checked if it makes sense to edit the field and it can be edited via FormEngine (e.g. not for bodytext in plugins). I could change commit msg to make that more clear.
  30. Sybille Peters uploaded patch set 12 11/04/21, 13:17

  31. Sybille Peters commented on patch set 12 CR -1 11/04/21, 13:18

    Needs more work. Does not meet current core standards currently. I just resolved merge conflicts. Also, should be decided first if / how we do this. - fix DI - ...
  32. core-ci voted on patch set 12 V -1 11/04/21, 13:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18880

  33. Sybille Peters rebased onto patch set 13 11/04/21, 16:26

  34. core-ci voted on patch set 13 V -1 11/04/21, 16:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18910

  35. Tymoteusz Motylewski commented on patch set 13 CR -1 11/05/21, 08:18

    on it
  36. Tymoteusz Motylewski uploaded patch set 14 11/05/21, 08:19

  37. Tymoteusz Motylewski commented on patch set 14 11/05/21, 08:20

    I've added BE user initialization, so tests dont complain on undefined BE_USER
  38. Tymoteusz Motylewski uploaded patch set 15 11/05/21, 08:36

  39. core-ci voted on patch set 15 V -1 11/05/21, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18928

  40. Tymoteusz Motylewski uploaded patch set 16 11/05/21, 08:44

  41. core-ci voted on patch set 14 V -1 11/05/21, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18927

  42. Tymoteusz Motylewski uploaded patch set 17 11/05/21, 08:58

  43. core-ci voted on patch set 16 V -1 11/05/21, 09:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18930

  44. Tymoteusz Motylewski uploaded patch set 18 11/05/21, 09:10

  45. core-ci voted on patch set 17 V -1 11/05/21, 09:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18931

  46. core-ci voted on patch set 18 V +1 11/05/21, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18933

  47. Tymoteusz Motylewski rebased onto patch set 19 11/15/21, 19:35

  48. core-ci voted on patch set 19 V +1 11/15/21, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19316

  49. Benni Mack updated the commit message in patch set 20 11/18/21, 10:49

  50. core-ci voted on patch set 20 V -1 11/18/21, 12:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19480

  51. core-ci voted on patch set 20 V +1 11/21/21, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19480

  52. Sybille Peters uploaded patch set 21 11/21/21, 16:19

  53. Sybille Peters marked it work in progress 11/21/21, 16:28

  1. core-ci voted on patch set 21 V +1 11/21/21, 16:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19609

  2. Benni Mack wrote 11/29/21, 10:21

    Change destination moved from master to main
  3. Benni Mack updated the commit message in patch set 22 11/29/21, 14:10

  4. core-ci voted on patch set 22 V +1 11/29/21, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20110

  5. Benni Mack commented on patch set 22 02/10/25, 20:01

    we can finally work on this again without FormEngine!
  6. Benni Mack uploaded patch set 23 V +1 01/18/26, 20:55

  7. core-ci voted on patch set 23 V +1 01/18/26, 21:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93732

  8. Benni Mack uploaded patch set 24 V +1 01/19/26, 10:21

  9. core-ci voted on patch set 24 V +1 01/19/26, 10:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/93762

  10. Benni Mack marked it ready for review 01/19/26, 19:25

  11. Benni Mack rebased onto patch set 25 V +1 01/23/26, 00:39

  12. core-ci voted on patch set 25 V +1 01/23/26, 00:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/94109

  13. Benni Mack wrote 04/21/26, 14:52

    Removed cc Benni Mack.
  14. Benni Mack marked it work in progress 04/21/26, 14:52

  15. Benni Mack uploaded patch set 26 V +1 09/22/26, 18:51

  16. Benni Mack marked it ready for review 09/22/26, 18:52

  17. Benni Mack voted on patch set 26 CR +1 V +1 09/22/26, 18:52

  18. core-ci voted on patch set 26 V +1 09/22/26, 19:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109008

  19. Simon Schaufelberger commented on patch set 26 09/22/26, 19:16

    LinkAnalyzerTest.php:302

    why not use yield here?

    LinkAnalyzerTest.php:304

    this should be in the line above and the whole nesting one level to the left
  20. Benni Mack uploaded patch set 27 CR +1 V +1 09/23/26, 12:48

  21. Benni Mack commented on patch set 27 CR +1 V +1 09/23/26, 12:48

    LinkAnalyzerTest.php:302 Reply

    Done

    LinkAnalyzerTest.php:304 Reply

    Done
  22. core-ci voted on patch set 27 V +1 09/23/26, 12:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109056

  23. Simon Schaufelberger voted on patch set 27 CR +1 V +1 09/23/26, 13:08

  24. Benni Mack voted on patch set 27 CR +2 V +2 09/23/26, 13:15

  25. Benni Mack merged patch set 28 09/23/26, 13:15