Review 10.4 Merged

66674[BUGFIX] Assume image dimension of SVGs with no dimension

Georg Ringer CR +2 V +2 Easy +14 −2 updated 11/17/20, 18:37

Commit message

Extracting SVG processing to its own processor did not
respect that previously SVG files without dimensions were
handled as a side effect of undefined behaviour without
causing hard errors. The new processor however throws
an exception instead of accepting undefined behaviour, which
causes old installations with such SVG files to break.

As a mitigation (as long as no other correct behaviour is defined),
some default image dimensions are assumed for SVG files where
none can be properly determined.

This does not make SVG files without defined dimensions properly work,
but at least restores the previous behaviour of not throwing
an exception.

Additionally extracting SVG processing uncovered another bug
that existed, but never fully surfaced before.

Processed files that were updated, but in fact were using the
original file (like SVGs typically do) accessed the wrong storage
to fetch file infos, when the processed files were configured to
remain of a different storage. This is now properly checked as well.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 3