66694[BUGFIX] Respect language overlay type in Extbase
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 3
Files 6
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-88886-ExtbasePersistenceRespectsLanguageOverlayType.rstnew+67 −0
- typo3/sysext/extbase/Classes/Persistence/Generic/Storage/Typo3DbBackend.php+10 −3
- typo3/sysext/extbase/Classes/Persistence/Generic/Backend.php+4 −1
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/FileUploadControllerTest.php+23 −0
- typo3/sysext/extbase/Tests/Functional/Persistence/QueryLocalizedDataTest.php+11 −14
- typo3/sysext/extbase/Tests/Functional/Persistence/TranslatedSiteContentTest.php+1 −1
Review log 5584
Show 3859 earlier messages
-
Mathias Brodala uploaded patch set 1 11/18/20, 11:20
-
Mathias Brodala marked it work in progress 11/18/20, 11:20
-
TYPO3com voted on patch set 1 V -1 11/18/20, 11:31 Completed build in 11m 23s on Wed, 18 Nov, 11:31 AM Test Summary: 12 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7391
-
Mathias Brodala uploaded patch set 2 11/18/20, 14:12
-
TYPO3com voted on patch set 2 V -1 11/18/20, 14:24 Completed build in 11m 18s on Wed, 18 Nov, 02:24 PM Test Summary: 27 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7394
-
Mathias Brodala uploaded patch set 3 11/18/20, 14:41
-
TYPO3com voted on patch set 3 V -1 11/18/20, 14:52 Completed build in 10m 56s on Wed, 18 Nov, 02:52 PM Test Summary: 21 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7395
-
Mathias Brodala uploaded patch set 4 11/18/20, 15:04
-
TYPO3com voted on patch set 4 V -1 11/18/20, 15:16 Completed build in 11m 47s on Wed, 18 Nov, 03:16 PM Test Summary: 9 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7396
-
Mathias Brodala uploaded patch set 5 11/18/20, 15:25
-
Mathias Brodala uploaded patch set 6 11/18/20, 15:34
-
TYPO3com voted on patch set 5 V -1 11/18/20, 15:37 Completed build in 11m 14s on Wed, 18 Nov, 03:37 PM Test Summary: 6 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7397
-
Mathias Brodala wrote 11/18/20, 15:44
Topic set to extbase-language -
TYPO3com voted on patch set 6 V +1 11/18/20, 15:49 Completed build in 14m 16s on Wed, 18 Nov, 03:49 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7399
-
Mathias Brodala commented on patch set 6 11/18/20, 15:50
This change is ready for review. -
Markus Klein commented on patch set 6 11/18/20, 18:44
The commit message should describe the change that is made and not what might happen in the future. ;-) Please change the message so I understand by reading it what is changed in the code now -
Mathias Brodala updated the commit message in patch set 7 11/19/20, 07:41
-
Mathias Brodala commented on patch set 7 11/19/20, 07:42
Reply
You are right, I just did that. At the end I'll check whether we need an Important RST or at least an adjustment of the existing Important RST. -
Mathias Brodala commented on patch set 7 11/19/20, 07:43
Today I'll also check whether I can adjust/fix the test data instead. -
TYPO3com voted on patch set 7 V +1 11/19/20, 07:53 Completed build in 11m 46s on Thu, 19 Nov, 07:53 AM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7412
-
Mathias Brodala uploaded patch set 8 11/19/20, 08:41
-
TYPO3com voted on patch set 8 V +1 11/19/20, 08:53 Completed build in 11m 54s on Thu, 19 Nov, 08:53 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7413
-
Mathias Brodala uploaded patch set 9 11/19/20, 09:40
-
TYPO3com voted on patch set 9 V +1 11/19/20, 09:52 Completed build in 10m 30s on Thu, 19 Nov, 09:51 AM Test Summary: 73720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7414
-
Mathias Brodala uploaded patch set 10 11/19/20, 10:08
-
TYPO3com voted on patch set 10 V +1 11/19/20, 10:19 Completed build in 11m 10s on Thu, 19 Nov, 10:19 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7416
-
Mathias Brodala uploaded patch set 11 11/19/20, 10:35
-
TYPO3com voted on patch set 11 V +1 11/19/20, 10:47 Completed build in 11m 41s on Thu, 19 Nov, 10:47 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7418
-
Mathias Brodala uploaded patch set 12 02/05/21, 08:16
-
TYPO3com voted on patch set 12 V -1 02/05/21, 08:34 Completed build in 14m 01s on Fri, 5 Feb, 08:34 AM Test Summary: 141 of 32829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9281
-
core-ci voted on patch set 12 V -1 02/05/21, 08:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/399
-
Benni Mack commented on patch set 12 04/29/21, 14:05
mbrodala, since I've been around in this area recently, I think your fix is "legit" and should be continued. Care to update this one? -
Mathias Brodala commented on patch set 12 04/30/21, 06:48
Reply
Definitely but I'll need: 1) a decision on the changed behavior which cannot be avoided AFAIS 2) a good hint how to update the test fixtures (refindex) without falling into madness Quote from my Slack conversation with Markus and Timoteusz: > I'm not happy with the test coverage yet and see a possible inconsistency with fallbackType: free (see CE 301 in TranslatedSiteContentTest::danishDataProvider()) as well as retrieving standalone objects with custom queries and overlays if these objects actually match the requested language (see QueryLocalizedDataTest::customFindByUidOverlayEnabled()) > Where you already able to have a look at my fix? I'm confident about the fix itself since it guarantees the same (thus consistent) language mode for a whole object tree but as mentioned there are some possibly unexpected behavior changes. I'd like to clarify first if these should be "fixed" or are actually correct this way. -
Mathias Brodala marked it work in progress 05/12/21, 10:40
-
Benni Mack uploaded patch set 13 05/21/21, 15:19
-
Benni Mack commented on patch set 13 05/21/21, 15:19
Let's first extract the added tests (and the test-bugfix to rename "dutch" to "danish"). Will take care. -
core-ci voted on patch set 13 V -1 05/21/21, 15:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11782
-
Benni Mack uploaded patch set 14 08/05/21, 15:31
-
core-ci voted on patch set 14 V -1 08/05/21, 15:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14153
-
Mathias Brodala uploaded patch set 15 09/22/21, 14:41
-
Mathias Brodala commented on patch set 15 09/22/21, 14:43
Rebased on master and removed all tests since they where incomplete and will cause conflicts. -
core-ci voted on patch set 15 V -1 09/22/21, 15:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17046
-
Benni Mack wrote 11/29/21, 10:08
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 16 11/29/21, 13:28
-
core-ci voted on patch set 16 V -1 11/29/21, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20035
-
Benni Mack commented on patch set 16 07/31/23, 08:05
Hey Mathias, we've made changes to this code area in v12... can you check if this problem still exists? -
Benni Mack commented on patch set 16 01/20/24, 22:03
I wonder if this is now solved via https://review.typo3.org/c/Packages/TYPO3.CMS/+/75093 -
Mathias Brodala commented on patch set 16 01/25/24, 14:36
Reply
Right now the project which is affected by this issue is still on TYPO3v11 so I won't be able to test said change before upgrading to TYPO3v12. Hope to get this done ASAP. -
Mathias Brodala commented on patch set 16 05/15/24, 13:42
Reply
I was now finally able to check the mentioned change. Unfortunately it doesn't solve the described issue. I'll try to update this change here. -
Mathias Brodala uploaded patch set 17
V -105/21/24, 10:32 -
core-ci voted on patch set 17 V -1 05/21/24, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57990
-
Mathias Brodala rebased onto patch set 18
V -105/21/24, 12:34 -
core-ci voted on patch set 18 V -1 05/21/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58002
-
Benni Mack updated the commit message in patch set 19
V -110/18/24, 13:30 -
core-ci voted on patch set 19 V -1 10/18/24, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67980
-
Benni Mack rebased onto patch set 20
V -102/06/26, 09:02 -
core-ci voted on patch set 20 V -1 02/06/26, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95249
-
Kevin Lieser voted on patch set 20 V +1 02/06/26, 14:06
-
Mathias Brodala commented on patch set 20 02/06/26, 14:08
Reply
Done
-
Benni Mack uploaded patch set 21
V +102/08/26, 09:39 -
core-ci voted on patch set 21 V -1 02/08/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95402
-
Benni Mack commented on patch set 21 02/08/26, 13:54
I suggest we merge this one first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92743 -
Mathias Brodala commented on patch set 21 02/16/26, 08:50
Reply
I'm fine with either order. But for my change I need feedback if this is the way to go. Then I'll see if I can manage to update the tests. -
Benni Mack rebased onto patch set 22
V -102/26/26, 10:58 -
core-ci voted on patch set 22 V -1 02/26/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96899
-
Benni Mack rebased onto patch set 23
V -103/04/26, 15:49 -
core-ci voted on patch set 23 V -1 03/04/26, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97342
-
Benni Mack updated the commit message in patch set 24
V -106/07/26, 18:52 -
core-ci voted on patch set 24 V -1 06/07/26, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103091
-
Benni Mack rebased onto patch set 25
V -107/15/26, 15:08 -
core-ci voted on patch set 25 V -1 07/15/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104804
-
Benni Mack uploaded patch set 26
V -107/24/26, 14:48 -
Benni Mack uploaded patch set 27 07/24/26, 14:57
-
Benni Mack marked it ready for review 07/24/26, 14:57
-
core-ci voted on patch set 26 V +1 07/24/26, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105334
-
Benni Mack commented on patch set 27 07/24/26, 14:58
Reply
the failed test was very interesting, I identified another issue through this, will do a follow-up but let's get this one in now. -
core-ci voted on patch set 27 V -1 07/24/26, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105337
-
Benni Mack uploaded patch set 28
V -107/24/26, 15:19 -
core-ci voted on patch set 28 V +1 07/24/26, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105338
-
Benni Mack voted on patch set 28 CR +1 V +1 07/24/26, 15:34
-
Oliver Klee voted on patch set 28 V +1 07/24/26, 15:37
-
Markus Klein voted on patch set 28 CR +1 07/24/26, 16:14
-
Benni Mack voted on patch set 28 CR +2 V +2 07/24/26, 16:22
-
Benni Mack merged patch set 29 07/24/26, 16:22