Review main Merged

66694[BUGFIX] Respect language overlay type in Extbase

Mathias Brodala CR +2 V +2 Normal +116 −19 updated 07/24/26, 16:22

Commit message

The language overlay type is part of the language aspect which in
turn is populated based on the site language configuration.

When retrieving a root aggregate object from Extbase persistence or
when fetching related objects of an aggregate root, this resolved
overlay type and its fallback chain are now respected. This ensures
that translation behavior of Extbase is consistent with the regular
translation behavior of pages and content in TYPO3. Most notably,
sites configured with "fallbackType: strict" no longer receive
untranslated records or untranslated child objects from Extbase.

While the overlay type is now taken from the resolved language
aspect, the content language used for the overlay is still derived
from the actually fetched record where needed: When a translated
record is fetched directly by its uid, or when queries do not respect
the system language, records keep being overlaid to their own
language. Identity lookups in free mode ("fallbackType: free") map to
mixed overlay semantics, consistent with the handling of related
objects in the DataMapper.

Since frontend sub-requests of functional tests currently leak their
language context into the test scope, persistence assertions running
after such sub-requests explicitly reset the language aspect for now.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 5584

Show 3859 earlier messages
  1. Mathias Brodala uploaded patch set 1 11/18/20, 11:20

  2. Mathias Brodala marked it work in progress 11/18/20, 11:20

  3. TYPO3com voted on patch set 1 V -1 11/18/20, 11:31 Completed build in 11m 23s on Wed, 18 Nov, 11:31 AM Test Summary: 12 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7391

  4. Mathias Brodala uploaded patch set 2 11/18/20, 14:12

  5. TYPO3com voted on patch set 2 V -1 11/18/20, 14:24 Completed build in 11m 18s on Wed, 18 Nov, 02:24 PM Test Summary: 27 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7394

  6. Mathias Brodala uploaded patch set 3 11/18/20, 14:41

  7. TYPO3com voted on patch set 3 V -1 11/18/20, 14:52 Completed build in 10m 56s on Wed, 18 Nov, 02:52 PM Test Summary: 21 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7395

  8. Mathias Brodala uploaded patch set 4 11/18/20, 15:04

  9. TYPO3com voted on patch set 4 V -1 11/18/20, 15:16 Completed build in 11m 47s on Wed, 18 Nov, 03:16 PM Test Summary: 9 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7396

  10. Mathias Brodala uploaded patch set 5 11/18/20, 15:25

  11. Mathias Brodala uploaded patch set 6 11/18/20, 15:34

  12. TYPO3com voted on patch set 5 V -1 11/18/20, 15:37 Completed build in 11m 14s on Wed, 18 Nov, 03:37 PM Test Summary: 6 of 74204 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7397

  13. Mathias Brodala wrote 11/18/20, 15:44

    Topic set to extbase-language
  14. TYPO3com voted on patch set 6 V +1 11/18/20, 15:49 Completed build in 14m 16s on Wed, 18 Nov, 03:49 PM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7399

  15. Mathias Brodala commented on patch set 6 11/18/20, 15:50

    This change is ready for review.
  16. Markus Klein commented on patch set 6 11/18/20, 18:44

    The commit message should describe the change that is made and not what might happen in the future. ;-) Please change the message so I understand by reading it what is changed in the code now
  17. Mathias Brodala updated the commit message in patch set 7 11/19/20, 07:41

  18. Mathias Brodala commented on patch set 7 11/19/20, 07:42

    Reply

    You are right, I just did that. At the end I'll check whether we need an Important RST or at least an adjustment of the existing Important RST.
  19. Mathias Brodala commented on patch set 7 11/19/20, 07:43

    Today I'll also check whether I can adjust/fix the test data instead.
  20. TYPO3com voted on patch set 7 V +1 11/19/20, 07:53 Completed build in 11m 46s on Thu, 19 Nov, 07:53 AM Test Summary: 73719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7412

  21. Mathias Brodala uploaded patch set 8 11/19/20, 08:41

  22. TYPO3com voted on patch set 8 V +1 11/19/20, 08:53 Completed build in 11m 54s on Thu, 19 Nov, 08:53 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7413

  23. Mathias Brodala uploaded patch set 9 11/19/20, 09:40

  24. TYPO3com voted on patch set 9 V +1 11/19/20, 09:52 Completed build in 10m 30s on Thu, 19 Nov, 09:51 AM Test Summary: 73720 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7414

  25. Mathias Brodala uploaded patch set 10 11/19/20, 10:08

  26. TYPO3com voted on patch set 10 V +1 11/19/20, 10:19 Completed build in 11m 10s on Thu, 19 Nov, 10:19 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7416

  27. Mathias Brodala uploaded patch set 11 11/19/20, 10:35

  28. TYPO3com voted on patch set 11 V +1 11/19/20, 10:47 Completed build in 11m 41s on Thu, 19 Nov, 10:47 AM Test Summary: 73722 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7418

  29. Mathias Brodala uploaded patch set 12 02/05/21, 08:16

  30. TYPO3com voted on patch set 12 V -1 02/05/21, 08:34 Completed build in 14m 01s on Fri, 5 Feb, 08:34 AM Test Summary: 141 of 32829 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9281

  31. core-ci voted on patch set 12 V -1 02/05/21, 08:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/399

  32. Benni Mack commented on patch set 12 04/29/21, 14:05

    mbrodala, since I've been around in this area recently, I think your fix is "legit" and should be continued. Care to update this one?
  33. Mathias Brodala commented on patch set 12 04/30/21, 06:48

    Reply

    Definitely but I'll need: 1) a decision on the changed behavior which cannot be avoided AFAIS 2) a good hint how to update the test fixtures (refindex) without falling into madness Quote from my Slack conversation with Markus and Timoteusz: > I'm not happy with the test coverage yet and see a possible inconsistency with fallbackType: free (see CE 301 in TranslatedSiteContentTest::danishDataProvider()) as well as retrieving standalone objects with custom queries and overlays if these objects actually match the requested language (see QueryLocalizedDataTest::customFindByUidOverlayEnabled()) > Where you already able to have a look at my fix? I'm confident about the fix itself since it guarantees the same (thus consistent) language mode for a whole object tree but as mentioned there are some possibly unexpected behavior changes. I'd like to clarify first if these should be "fixed" or are actually correct this way.
  34. Mathias Brodala marked it work in progress 05/12/21, 10:40

  35. Benni Mack uploaded patch set 13 05/21/21, 15:19

  36. Benni Mack commented on patch set 13 05/21/21, 15:19

    Let's first extract the added tests (and the test-bugfix to rename "dutch" to "danish"). Will take care.
  37. core-ci voted on patch set 13 V -1 05/21/21, 15:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11782

  38. Benni Mack uploaded patch set 14 08/05/21, 15:31

  39. core-ci voted on patch set 14 V -1 08/05/21, 15:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14153

  40. Mathias Brodala uploaded patch set 15 09/22/21, 14:41

  41. Mathias Brodala commented on patch set 15 09/22/21, 14:43

    Rebased on master and removed all tests since they where incomplete and will cause conflicts.
  42. core-ci voted on patch set 15 V -1 09/22/21, 15:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/17046

  43. Benni Mack wrote 11/29/21, 10:08

    Change destination moved from master to main
  44. Benni Mack updated the commit message in patch set 16 11/29/21, 13:28

  45. core-ci voted on patch set 16 V -1 11/29/21, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20035

  46. Benni Mack commented on patch set 16 07/31/23, 08:05

    Hey Mathias, we've made changes to this code area in v12... can you check if this problem still exists?
  47. Benni Mack commented on patch set 16 01/20/24, 22:03

  48. Mathias Brodala commented on patch set 16 01/25/24, 14:36

    Reply

    Right now the project which is affected by this issue is still on TYPO3v11 so I won't be able to test said change before upgrading to TYPO3v12. Hope to get this done ASAP.
  49. Mathias Brodala commented on patch set 16 05/15/24, 13:42

    Reply

    I was now finally able to check the mentioned change. Unfortunately it doesn't solve the described issue. I'll try to update this change here.
  50. Mathias Brodala uploaded patch set 17 V -1 05/21/24, 10:32

  51. core-ci voted on patch set 17 V -1 05/21/24, 10:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57990

  52. Mathias Brodala rebased onto patch set 18 V -1 05/21/24, 12:34

  53. core-ci voted on patch set 18 V -1 05/21/24, 12:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/58002

  54. Benni Mack updated the commit message in patch set 19 V -1 10/18/24, 13:30

  55. core-ci voted on patch set 19 V -1 10/18/24, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/67980

  56. Benni Mack rebased onto patch set 20 V -1 02/06/26, 09:02

  57. core-ci voted on patch set 20 V -1 02/06/26, 09:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95249

  58. Kevin Lieser voted on patch set 20 V +1 02/06/26, 14:06

  59. Mathias Brodala commented on patch set 20 02/06/26, 14:08

    Reply

    Done
  1. Benni Mack uploaded patch set 21 V +1 02/08/26, 09:39

  2. core-ci voted on patch set 21 V -1 02/08/26, 09:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/95402

  3. Benni Mack commented on patch set 21 02/08/26, 13:54

  4. Mathias Brodala commented on patch set 21 02/16/26, 08:50

    Reply

    I'm fine with either order. But for my change I need feedback if this is the way to go. Then I'll see if I can manage to update the tests.
  5. Benni Mack rebased onto patch set 22 V -1 02/26/26, 10:58

  6. core-ci voted on patch set 22 V -1 02/26/26, 11:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/96899

  7. Benni Mack rebased onto patch set 23 V -1 03/04/26, 15:49

  8. core-ci voted on patch set 23 V -1 03/04/26, 16:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/97342

  9. Benni Mack updated the commit message in patch set 24 V -1 06/07/26, 18:52

  10. core-ci voted on patch set 24 V -1 06/07/26, 19:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/103091

  11. Benni Mack rebased onto patch set 25 V -1 07/15/26, 15:08

  12. core-ci voted on patch set 25 V -1 07/15/26, 15:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/104804

  13. Benni Mack uploaded patch set 26 V -1 07/24/26, 14:48

  14. Benni Mack uploaded patch set 27 07/24/26, 14:57

  15. Benni Mack marked it ready for review 07/24/26, 14:57

  16. core-ci voted on patch set 26 V +1 07/24/26, 14:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105334

  17. Benni Mack commented on patch set 27 07/24/26, 14:58

    Reply

    the failed test was very interesting, I identified another issue through this, will do a follow-up but let's get this one in now.
  18. core-ci voted on patch set 27 V -1 07/24/26, 15:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105337

  19. Benni Mack uploaded patch set 28 V -1 07/24/26, 15:19

  20. core-ci voted on patch set 28 V +1 07/24/26, 15:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/105338

  21. Benni Mack voted on patch set 28 CR +1 V +1 07/24/26, 15:34

  22. Oliver Klee voted on patch set 28 V +1 07/24/26, 15:37

  23. Markus Klein voted on patch set 28 CR +1 07/24/26, 16:14

  24. Benni Mack voted on patch set 28 CR +2 V +2 07/24/26, 16:22

  25. Benni Mack merged patch set 29 07/24/26, 16:22