Review main Merged

66892[TASK] Deprecate calling AbstractTreeView::getIcon() with records uid

Oli Bartsch CR +2 V +2 Normal +52 −5 updated 11/27/20, 08:25

Commit message

Calling `AbstractTreeView::getIcon()` with the records uid as
first argument is deprecated. This helps to increase type safety
through the core and also properly reflects the expected value
for the parameter, as its name is `$row`.

Side note: There was no benefit in providing just the records uid
since the full record was fetched in that case anyways internally,
but without adding any restrictions or respecting any overlays.

Because the method returns a string in any case, the return type
is furthermore added to the method signature.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3