66898[FEATURE] Add a fax (fax:) and an sms (sms:) link handler
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 21
- typo3/sysext/backend/Classes/Form/Element/InputLinkElement.php+18 −0
- typo3/sysext/backend/Configuration/SiteConfiguration/site_errorhandling.php+1 −1
- typo3/sysext/backend/Configuration/SiteConfiguration/site_route.php+1 −1
- typo3/sysext/core/Classes/LinkHandling/FaxLinkHandler.phpnew+50 −0
- typo3/sysext/core/Classes/LinkHandling/LegacyLinkNotationConverter.php+6 −0
- typo3/sysext/core/Classes/LinkHandling/LinkService.php+8 −0
- typo3/sysext/core/Classes/LinkHandling/SmsLinkHandler.phpnew+50 −0
- typo3/sysext/core/Configuration/DefaultConfiguration.php+11 −7
- typo3/sysext/core/Documentation/Changelog/master/Feature-92928-ImplementLinkHandlersForFaxAndSMSNumbers.rstnew+11 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/FaxLinkHandlerTest.phpnew+104 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/SmsLinkHandlerTest.phpnew+104 −0
- typo3/sysext/frontend/Classes/Typolink/FaxLinkBuilder.phpnew+32 −0
- typo3/sysext/frontend/Classes/Typolink/SmsLinkBuilder.phpnew+32 −0
- typo3/sysext/recordlist/Classes/LinkHandler/FaxLinkHandler.phpnew+109 −0
- typo3/sysext/recordlist/Classes/LinkHandler/SmsLinkHandler.phpnew+109 −0
- typo3/sysext/recordlist/Resources/Private/Language/locallang_browse_links.xlf+12 −0
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Fax.htmlnew+19 −0
- typo3/sysext/recordlist/Resources/Private/Templates/LinkBrowser/Sms.htmlnew+19 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/FaxLinkHandler.jsnew+13 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/SmsLinkHandler.jsnew+13 −0
Show 1 more file
Review log 1112
-
Cyril Janody uploaded patch set 1 11/25/20, 02:25
-
TYPO3com voted on patch set 1 V +1 11/25/20, 02:36 Completed build in 11m 02s on Wed, 25 Nov, 02:36 AM Test Summary: 32423 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7564
-
Mathias Brodala commented on patch set 1 11/25/20, 07:41
TBH I don't think these should be integrated, they could be provided as a 3rd party package just fine. Both Fax and SMS are ancient/old and not even used everywhere around the world compared to phone. Also if at all it should be considered to extend the phone link handler to support these two. -
Cyril Janody commented on patch set 1 11/25/20, 14:12
> Patch Set 1: > > TBH I don't think these should be integrated, they could be provided as a 3rd party package just fine. Both Fax and SMS are ancient/old and not even used everywhere around the world compared to phone. Also if at all it should be considered to extend the phone link handler to support these two. Well, just because these are old tech doesn't mean organizations aren't using them (Governmental, Para-Governmental..). -
Mathias Brodala commented on patch set 1 11/25/20, 14:14
> Patch Set 1: > > > Patch Set 1: > > > > TBH I don't think these should be integrated, they could be provided as a 3rd party package just fine. Both Fax and SMS are ancient/old and not even used everywhere around the world compared to phone. Also if at all it should be considered to extend the phone link handler to support these two. > > Well, just because these are old tech doesn't mean organizations aren't using them (Governmental, Para-Governmental..). That's true but the same could be said about gopher:// and similar. ;-) -
Oli Bartsch commented on patch set 1 11/25/20, 15:20
> Patch Set 1: > > > Patch Set 1: > > > > > Patch Set 1: > > > > > > TBH I don't think these should be integrated, they could be provided as a 3rd party package just fine. Both Fax and SMS are ancient/old and not even used everywhere around the world compared to phone. Also if at all it should be considered to extend the phone link handler to support these two. > > > > Well, just because these are old tech doesn't mean organizations aren't using them (Governmental, Para-Governmental..). > > That's true but the same could be said about gopher:// and similar. ;-) I think, regardless of whether these are still used or not, this can easily being provided as a community extensions. Or are there currently any limitations in Core API, preventing such integration? If so this should be definitely fixed. But adding one handler after another doesn't sound reasonable to me, since that's basically what extensions are for, extending Core for custom purposes through the public APIs. -
Cyril Janody commented on patch set 1 11/26/20, 13:58
> Patch Set 1: > > > Patch Set 1: > > > > > Patch Set 1: > > > > > > > Patch Set 1: > > > > > > > > TBH I don't think these should be integrated, they could be provided as a 3rd party package just fine. Both Fax and SMS are ancient/old and not even used everywhere around the world compared to phone. Also if at all it should be considered to extend the phone link handler to support these two. > > > > > > Well, just because these are old tech doesn't mean organizations aren't using them (Governmental, Para-Governmental..). > > > > That's true but the same could be said about gopher:// and similar. ;-) > > I think, regardless of whether these are still used or not, this can easily being provided as a community extensions. Or are there currently any limitations in Core API, preventing such integration? If so this should be definitely fixed. But adding one handler after another doesn't sound reasonable to me, since that's basically what extensions are for, extending Core for custom purposes through the public APIs. I agree, it could be in an extension like the telephone link handler was! But I don't think standards are custom things / purposes. -
Daniel Haupt commented on patch set 1 11/26/20, 22:33
> I agree, it could be in an extension like the telephone link handler was! > But I don't think standards are custom things / purposes. I can understand your point of view, but I can not imagine this will be a widely used feature at all. If I had to create an extension, I would try to implement the two protocols into the existing phone link handler e.g. with a type selection in order to reuse existing functionality as the protocols are very similar. -
Cyril Janody commented on patch set 1 11/27/20, 14:24
> Patch Set 1: > > > I agree, it could be in an extension like the telephone link handler was! > > But I don't think standards are custom things / purposes. > > I can understand your point of view, but I can not imagine this will be a widely used feature at all. > > If I had to create an extension, I would try to implement the two protocols into the existing phone link handler e.g. with a type selection in order to reuse existing functionality as the protocols are very similar. All right. -
Daniel Haupt commented on patch set 1 11/27/20, 14:36
> All right. I hope you did not take the feedback as too negative. Thanks a lot for your engagement! -
Cyril Janody commented on patch set 1 11/27/20, 15:59
> Patch Set 1: > > > All right. > I hope you did not take the feedback as too negative. > > Thanks a lot for your engagement! No problem, I understand. Regards -
Cyril Janody abandoned the change 11/27/20, 19:22