Review main Merged Breaking

66968[!!!][TASK] Do not handle deleted records in reference index

Christian Kuhn CR +2 V +2 Impossible +11518 −11707 updated 12/08/20, 21:54

Commit message

Keeping relation information for soft deleted records
in sys_refindex is quite useless: When records are
undeleted, the reference index is updated to recreate
rows. Additionally, the deleted handling was incomplete,
especially if a record on the 'right' side of the relation
got deleted.

The patch drops the deleted field from the table and
prevents adding relations for soft deleted rows.
Furthermore, visibility of a couple of properties and
methods is changed to protected and a series of not used
methods is removed.

Note the hash sums change due to the removal of the deleted
field. The CLI command "bin/typo3 referenceindex:update"
will update hashes and will drop obsolete deleted rows.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 860

Show 840 more files