Review main Abandoned Breaking

66995[!!!][TASK] Remove SingletonInterface from prototype classes

Benni Mack CR 0 V 0 Normal +107 −46 updated 12/09/20, 12:23

Commit message

Back in TYPO3 v4 / PHP5 age, the singleton interface
was added to a lot of classes to limit performance
issues, which is not needed anymore in PHP7
times.

This change removes unneeded singleton instances,
leaving Extbase Persistence, Factories and Manager
classes as is for the time being.

In addition, the mentioned classes do not carry relevant
state, and only need to be registered in DI if they
need auto-wiring (= dependencies in any kind of way)
in place. DI can also mark classes as "shared" which
is not needed in the changed classes.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 25

Show 5 more files