Review main Merged

67032[FEATURE] Only set cookies for HTTP Responses in PSR-15 middlewares

Benni Mack CR +2 V +2 Normal +110 −30 updated 12/08/20, 07:40

Commit message

In previous TYPO3 versions, AbstractUserAuthentication emitted
cookies directly via header() or setcookie() methods.

In order to have a better testing scenario, this change
builds Cookie objects and keeps them until a PSR-15 middleware
asks to apply the cookie information to a PSR-7 Response.

This also makes it possible to manipulate the authentication
cookies in Middlewares.

AbstractUserAuthentication does not actually "remove"
or "set" a cookie but rather keeps the information for
setting a cookie.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5