Review main Merged Breaking

67033[!!!][TASK] PageRenderer should only render a full page

Benni Mack CR +2 V +2 Normal +92 −24 updated 12/07/20, 10:31

Commit message

PageRenderer->render() does not accept any arguments anymore.

This change allows to later-on hand in a Request object
into the PageRenderer and/or continue building a generic
View for rendering content, without marker-based changes.

In addition, the corresponding constants are now marked as
protected.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6