Review main Merged Breaking

67034[!!!][FEATURE] Move BE Group Resolving into separate functionality

Benni Mack CR +2 V +2 Hard +334 −100 updated 12/14/20, 17:07

Commit message

In order to re-use the group resolving, this logic
is now extract from AbstractUserAuthentication,
allowing to further optimize this code.

The hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauthgroup.php']['fetchGroups_postProcessing']
is removed and replaced by a PSR-14 event to modify the Group Data.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 1527

Show 12 earlier messages
  1. Benni Mack uploaded patch set 1 12/06/20, 12:58

  2. TYPO3com voted on patch set 1 V -1 12/06/20, 13:03 Completed build in 05m 29s on Sun, 6 Dec, 01:03 PM Test Summary: 11618 of 32552 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7852

  1. Benni Mack uploaded patch set 2 12/10/20, 16:56

  2. TYPO3com voted on patch set 2 V -1 12/10/20, 17:08 Completed build in 12m 09s on Thu, 10 Dec, 05:08 PM Test Summary: 11618 of 32552 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8025

  3. Benni Mack uploaded patch set 3 12/10/20, 20:15

  4. TYPO3com voted on patch set 3 V -1 12/10/20, 20:23 Completed build in 08m 41s on Thu, 10 Dec, 08:23 PM Test Summary: 88 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8030

  5. Benni Mack uploaded patch set 4 12/10/20, 21:19

  6. TYPO3com voted on patch set 4 V +1 12/10/20, 21:38 Completed build in 14m 17s on Thu, 10 Dec, 09:38 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8036

  7. Benni Mack uploaded patch set 5 12/11/20, 07:50

  8. TYPO3com voted on patch set 5 V +1 12/11/20, 07:59 Completed build in 08m 55s on Fri, 11 Dec, 07:59 AM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8051

  9. Benni Mack updated the commit message in patch set 6 12/11/20, 11:37

  10. TYPO3com voted on patch set 6 V -1 12/11/20, 11:47 Completed build in 10m 23s on Fri, 11 Dec, 11:47 AM Test Summary: 31589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8061

  11. Benni Mack uploaded patch set 7 12/12/20, 17:23

  12. TYPO3com voted on patch set 7 V -1 12/12/20, 17:34 Completed build in 10m 55s on Sat, 12 Dec, 05:34 PM Test Summary: 3 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8128

  13. Benni Mack uploaded patch set 8 12/14/20, 08:40

  14. TYPO3com voted on patch set 8 V -1 12/14/20, 08:49 Completed build in 09m 13s on Mon, 14 Dec, 08:49 AM Test Summary: 1 of 32657 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8142

  15. TYPO3com voted on patch set 8 V +1 12/14/20, 10:06 Completed build in 1h 35m 26s on Mon, 14 Dec, 10:06 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8142

  16. Benni Mack uploaded patch set 9 12/14/20, 11:07

  17. TYPO3com voted on patch set 9 V -1 12/14/20, 11:18 Completed build in 10m 35s on Mon, 14 Dec, 11:17 AM Test Summary: 32404 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8150

  18. TYPO3com voted on patch set 9 V +1 12/14/20, 11:28 Completed build in 31m 53s on Mon, 14 Dec, 11:28 AM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8150

  19. Christian Kuhn commented on patch set 9 CR -1 12/14/20, 15:16

    on it.
  20. Christian Kuhn uploaded patch set 10 12/14/20, 15:58

  21. Christian Kuhn voted on patch set 10 V +1 CR +1 12/14/20, 15:59

  22. TYPO3com voted on patch set 10 V +1 12/14/20, 16:08 Completed build in 09m 52s on Mon, 14 Dec, 04:08 PM Test Summary: 32415 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8172

  23. Oli Bartsch voted on patch set 10 V +1 CR +1 12/14/20, 17:05

  24. Benni Mack voted on patch set 10 V +2 CR +2 12/14/20, 17:07

  25. Benni Mack merged patch set 11 12/14/20, 17:07