Review main Merged

67039[BUGFIX] Mark broken links to hidden page and CEs

Sybille Peters CR +2 V +2 Easy +30 −9 updated 01/06/22, 18:34

Commit message

Broken links are marked in RTE by using the attribute
data-rte-error in the <a> tag, which results in a
special style and lets the link be visible as broken.

Previously this was not done for links to hidden pages
and links to content elements. These links were however
detected as broken by linkvalidator and displayed in
the list of broken links. Marking them in RTE as well
makes the behaviour consistent.

This patch ensures the consistency between the list
and the visual highlighting in RTE elements for links
to hidden pages and hidden content elements.

Highlighting links to hidden pages/content elements
on hidden pages may be visually relaxed to a notice
instead of an error in a dedicated patch as feature.

One PHP8.0 array key warning is fixed along the way.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3