Review main Merged

67076[TASK] Cleanup ReferenceIndex class

Christian Kuhn CR +2 V +2 Hard +128 −153 updated 12/09/20, 15:16

Commit message

* Since introduction of class ReferenceIndexUpdater each
  record is handled only once when updating the reference
  index. The record runtime cache is obsolete and can be
  dropped.

* The $excludedTables and $excludedColumns properties are
  non-static now: In normal operation only one instance
  of ReferenceIndex class is created and used for many
  records, there is no point in creating hard to evict
  static state.

* A runtime cache has been used for information derived
  from TCA (no db calls). This is dropped in favor of a
  class property.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 11