Review main Merged

67089[TASK] Remove obsolete state for group resolving in BE_USER

Benni Mack CR +2 V +2 Normal +42 −66 updated 12/10/20, 23:02

Commit message

The internal public property BE_USER->dataLists is removed
as all data is now directly written into groupData now.

This is part of a larger clean up of legacy code of
UserAuthentication.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1016

  1. Benni Mack uploaded patch set 1 12/10/20, 22:02

  2. Benni Mack commented on patch set 2 12/10/20, 22:07

    Published edit on patch set 1.
  3. Oliver Hader commented on patch set 2 12/10/20, 22:11

    BackendUserAuthentication.php:1449

    s
  4. Benni Mack commented on patch set 3 12/10/20, 22:14

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 1 V -1 12/10/20, 22:16 Completed build in 13m 24s on Thu, 10 Dec, 10:16 PM Test Summary: 1 of 31395 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8037

  6. Oliver Hader voted on patch set 3 CR +1 12/10/20, 22:22

  7. TYPO3com voted on patch set 2 V -1 12/10/20, 22:23 Completed build in 15m 19s on Thu, 10 Dec, 10:23 PM Test Summary: 32039 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8038

  8. TYPO3com voted on patch set 3 V -1 12/10/20, 22:29 Completed build in 13m 16s on Thu, 10 Dec, 10:29 PM Test Summary: 13 of 32654 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8039

  9. TYPO3com voted on patch set 1 V +1 12/10/20, 22:31 Completed build in 41m 24s on Thu, 10 Dec, 10:30 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8037

  10. TYPO3com voted on patch set 3 V +1 12/10/20, 22:36 Completed build in 33m 54s on Thu, 10 Dec, 10:36 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8039

  11. Wouter Wolters voted on patch set 3 CR +1 12/10/20, 22:37

  12. Benni Mack commented on patch set 3 12/10/20, 22:41

    BackendUserAuthentication.php:1449 Reply

    Ack
  13. TYPO3com commented on patch set 3 12/10/20, 22:43 Completed build in 10m 26s on Thu, 10 Dec, 10:43 PM Test Summary: 32413 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8040

  14. Georg Ringer voted on patch set 3 V +1 CR +1 12/10/20, 22:54

  15. Oliver Hader voted on patch set 3 V +2 CR +2 12/10/20, 23:02

  16. Oliver Hader merged patch set 4 12/10/20, 23:02