Review main Merged

67103[BUGFIX] Ensure new session handling works in SQLite environments

Benni Mack CR +2 V +2 Easy +14 −13 updated 12/14/20, 08:22

Commit message

Due to some missing casting and usage of wrong properties,
a wrong comparison happened.

In addition, the change now checks for "user" instead of "userSession",
as the "userSession" property is obsolete.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Benni Mack uploaded patch set 1 12/12/20, 10:16

  2. Oliver Klee voted on patch set 1 CR +1 12/12/20, 10:26

  3. TYPO3com voted on patch set 1 V +1 12/12/20, 10:27 Completed build in 11m 13s on Sat, 12 Dec, 10:27 AM Test Summary: 32411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8111

  4. Christian Kuhn voted on patch set 1 CR +1 12/12/20, 11:10

  5. Christian Kuhn commented on patch set 1 CR 0 12/12/20, 11:39

    AbstractUserAuthentication.php:592

    why do you swap this? $tempuser is basically the recently fetched user session record and $this->user is some older data?

    AbstractUserAuthentication.php:602

    sure about this?
  6. Benni Mack commented on patch set 1 12/12/20, 11:41

    AbstractUserAuthentication.php:592 Reply

    I agree, however I wanted to avoid side-effects as this was the same case before we migrated to the new UserSession

    AbstractUserAuthentication.php:602 Reply

    Check your IDE. This code (since a long time) says "Hey, this is always true" :D
  7. Christian Kuhn commented on patch set 1 V +1 CR +1 12/12/20, 11:44

    AbstractUserAuthentication.php:592 Reply

    ah, ok. fine then.

    AbstractUserAuthentication.php:602 Reply

    ah. right. yes.
  8. Benni Mack commented on patch set 1 12/12/20, 12:51

    @Markus: can we add this change and fix the others separately?
  9. Michael Schams commented on patch set 1 V +1 12/13/20, 03:44

    3291364.diff works for me.
  10. Markus Klein uploaded patch set 2 12/13/20, 14:03

  11. Markus Klein commented on patch set 2 V +1 CR +1 12/13/20, 14:04

    I added the two missing changes (text only)
  12. TYPO3com voted on patch set 2 V -1 12/13/20, 14:12 Completed build in 08m 40s on Sun, 13 Dec, 02:12 PM Test Summary: 1 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8133

  13. TYPO3com commented on patch set 2 12/13/20, 19:36 Completed build in 5h 41m 46s on Sun, 13 Dec, 07:36 PM Test Summary: 1 of 32655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8133

  14. Benni Mack rebased onto patch set 3 12/13/20, 20:15

  15. TYPO3com voted on patch set 3 V +1 12/13/20, 20:32 Completed build in 15m 58s on Sun, 13 Dec, 08:32 PM Test Summary: 32414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8137

  16. Markus Klein voted on patch set 3 V +1 CR +1 12/13/20, 22:58

  17. Georg Ringer voted on patch set 3 V +2 CR +2 12/14/20, 08:22

  18. Georg Ringer merged patch set 4 12/14/20, 08:22