Review main Abandoned

67234[BUGFIX] Process cropped images only once

Markus Klein CR 0 V 0 Normal +79 −86 updated 04/17/24, 15:57

Commit message

To avoid loss of quality and spawning unnecessary imagemagick
processes, cropping and scaling of images is now done
with a single imagemagick process.

By doing so, the code for SVG processing is streamlined.
SVG processing code can further be improved later,
by putting it into a dedicated file processing task processor.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 79

  1. Markus Klein uploaded patch set 1 12/21/20, 23:54

  2. TYPO3com voted on patch set 1 V -1 12/22/20, 00:06 Completed build in 11m 06s on Tue, 22 Dec, 12:06 AM Test Summary: 9 of 32769 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8414

  3. Markus Klein marked it work in progress 12/22/20, 16:16

  4. Markus Klein updated the commit message in patch set 2 12/22/20, 16:16

  5. TYPO3com voted on patch set 2 V +1 12/22/20, 16:27 Completed build in 10m 32s on Tue, 22 Dec, 04:27 PM Test Summary: 32540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8440

  6. Benni Mack wrote 11/29/21, 10:03

    Change destination moved from master to main
  7. Benni Mack updated the commit message in patch set 3 11/29/21, 13:13

  8. Andreas Kienast abandoned the change 04/17/24, 12:07

    Hey Markus. The issue was handled with https://review.typo3.org/c/Packages/TYPO3.CMS/+/83299 a few weeks ago. I'll therefore abandon this patch.
  9. Markus Klein commented on patch set 3 04/17/24, 15:57

    Thanks Andy!