Review 10.4 Merged

67306[BUGFIX] Streamline frontend 5xx error handling

Christian Kuhn CR +2 V +2 Normal +176 −32 updated 01/06/21, 13:36

Commit message

* Fix 500 vs 503 error for configuration vs maintenance errors
 * Fix maintenance mode middleware ordering to get access to site
   related error handlers
 * Fix ErrorController unit tests to actually test
   for 503 and 500 error responses (contained duplicate
   code that didn't actually test for the non-configured
   state, but the devIPMask state)

For 5xx status code we have two different cases right now:
 * configuration errors, which need to respond with 500
 * maintenance mode, which is a 503 response

Therefore TSFE now uses internalErrorAction()
to respond with "500 Internal Server Error" when
the page configuration is broken.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 6