Review 10.4 Merged

67312[BUGFIX] Load dependencies of ImmediateActionElement dynamically

Benjamin Franzke CR +2 V +2 Easy +14 −10 updated 12/29/20, 16:56

Commit message

The module ImmediateActionElement is used to render a defined custom
HTML tag triggering certain actions once it's rendered, like reloading
the module menu or the backend's topbar. To achieve this, it needs
functionality from the modules TYPO3.ModuleMenu.App.refreshMenu and
TYPO3.Backend.Topbar.refresh.

This module is loaded at a very early stage where those dependencies
cannot do anything meaningful as there is nothing to do, namely the
backend login, which causes JavaScript warnings and increases loading
time.

To relax the situation, the modules are now loaded dynamically when
required by using async functions.

In a perfect world, there would be some kind of a hooking system and no
hardcoded list of actions, but we're not there, yet.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4