Review main Merged

67313[TASK] Use core AjaxRequest instead d3.request

Benjamin Franzke CR +2 V +2 Hard +132 −139 updated 01/01/21, 13:54

Commit message

d3 is currently manually patched to avoid a
d3.request()/d3.json() bug in chome >= 64 – see #83741.
The patch has not been merged in two years, and d3.request
is deprecated, so it is now replaced.
This will also help to upgrade to D3.js v5/v6 at some
point.

This allows to use an unpatched, vanilla D3.js build again.
While at it, we also streamline the contrib path to avoid the
unecessary d3/ subdirectory.

Commands used:

  grunt build

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 6