Review main Abandoned

67350[BUGFIX] Fix sqlite DB migrations

Markus Klein CR 0 V 0 Easy +1 −1 updated 01/07/21, 15:31

Commit message

The DB schema migrator for sqlite needs to create
several queries to rename or remove DB fields.
E.g. it needs to remove indexes first.

Having multiple such operations on the same table
causes the needed "DROP INDEX..." statements to show up in the Analyzer
listing multiple times.

When executing the statements the calculated list of statements then
holds an array of SQL statements instead of a single statement (as
string) causing the migration to fail.

The fix makes sure that this array of identical SQL statements is never
generated by adjusting the used PHP array-function.

Review

  • Code review CR 0
  • Verified V 0

Files 1

Review log 23

  1. Markus Klein uploaded patch set 1 01/06/21, 14:32

  2. TYPO3com voted on patch set 1 V +1 01/06/21, 14:46 Completed build in 13m 32s on Wed, 6 Jan, 02:46 PM Test Summary: 32565 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8686

  3. Markus Klein abandoned the change 01/07/21, 15:31

    failing to reproduce this properly