67361[TASK] Remove language information in page/list module if not needed
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1720
-
Georg Ringer uploaded patch set 1 01/08/21, 09:06
-
Georg Ringer commented on patch set 1 01/08/21, 09:06
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 01/08/21, 09:17 Completed build in 11m 09s on Fri, 8 Jan, 09:17 AM Test Summary: 32569 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8752
-
Oli Bartsch commented on patch set 1 CR -1 01/08/21, 09:33
There are obviously more modules which need to be unified then. E.g. workspaces.GridColumnItem.php:173Calling the above three lines for every single item over an over again does not seem to make sense - performance wise. Especially in multi language setups with a lot of content elements. What about some general flag for this? -
Benni Mack commented on patch set 1 01/08/21, 12:23
GridColumnItem.php:173Replyhmm, I don't know a better solution actually without going much into the Fluid-Page-Module hell. In addition, I think it's not a huge performance problem tbh, as this is standard PHP getters / loops. ... the longer I think of it... maybe we could check for the site directly and ask for the languages of the site. Otherwise a translator with only one language accessible does not see the language flags anymore. -
Daniel Goerz commented on patch set 1 01/08/21, 12:31
GridColumnItem.php:173ReplyThe better solution would be to move this logic into the Context object and have a getter for it, too. if ($context->hasTranslations()) -
Oli Bartsch commented on patch set 1 01/08/21, 13:09
GridColumnItem.php:173Reply Unresolved+1. That was actually my idea with the "some general flag". -
Xavier Perseguers commented on patch set 1 02/19/21, 14:41
Could we please get this into v10 as well? v9 was clean, v10 is not anymore. -
Claus Due uploaded patch set 2 08/13/21, 11:20
-
core-ci voted on patch set 2 V -1 08/13/21, 11:44 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14945
-
Claus Due uploaded patch set 3 08/13/21, 13:02
-
core-ci voted on patch set 3 V +1 08/13/21, 13:22 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14964
-
Andreas Kienast commented on patch set 3 CR -1 08/13/21, 13:27
PageLayoutContext.php:126Why do I need at least three languages to have "multiple" languages? -
Claus Due commented on patch set 3 08/13/21, 13:33
PageLayoutContext.php:126ReplyOne is the "all languages" virtual language (index -1) Second is the "default language" semi-virtual language (index 0) Third and subsequent languages are the actual additional languages (index 1 and above) So a condition of > 2 means "are there any languages defined in addition to all languages and default language". -
Andreas Kienast commented on patch set 3 CR 0 08/13/21, 13:37
PageLayoutContext.php:126ReplyI see, thanks for the explanation. -
Oli Bartsch commented on patch set 3 CR -1 08/17/21, 13:24
PageLayoutContext.php:126Reply UnresolvedHowever, counting languages does not look sufficient here. What if user has no access to -1? In this case the check is wrong. Please let's make this explicit with something like: array_filter($this->siteLanguages, static fn (SiteLanguage $language) => $language->getLanguageId() > 0) !== []; -
Benni Mack commented on patch set 3 10/15/21, 12:11
What's the status here? AFAICS this has been fixed differently in master / v11. -
Georg Ringer abandoned the change 10/19/21, 18:44
still unresolved in master but abandoned now -
Georg Ringer restored the change 02/26/25, 19:56
-
Georg Ringer abandoned the change 02/26/25, 20:16
abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/88374