Review main Merged

67448[BUGFIX] Use correct parameter for fetching TSconfig

Oli Bartsch CR +2 V +2 Easy +4 −7 updated 01/25/21, 10:41

Commit message

The ListController now uses the correct parameter for
fetching the TCEFORM TSconfig options.

Furthermore is the `fieldName` now added as url
parameter in the FieldControl. This allows replacing
the pid based on the defined TSConfig for the current
field in the ListController again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 912

  1. Oli Bartsch uploaded patch set 1 01/14/21, 14:05

  2. TYPO3com voted on patch set 1 V -1 01/14/21, 15:42 Completed build in 09m 22s on Thu, 14 Jan, 03:42 PM Test Summary: 1 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8855

  3. TYPO3com voted on patch set 1 V +1 01/14/21, 15:47 Completed build in 23m 21s on Thu, 14 Jan, 03:47 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8855

  4. Benni Mack voted on patch set 1 V +1 CR +1 01/15/21, 17:03

  5. Daniel Goerz commented on patch set 1 CR -1 01/16/21, 11:29

    ListController.php:49

    $parameters can be null. also those keys might not exist.

    ListController.php:51

    $parameters can be null. also those key might not exist.
  6. Oli Bartsch uploaded patch set 2 01/16/21, 12:41

  7. Oli Bartsch commented on patch set 1 01/16/21, 12:43

    ListController.php:49 Reply Unresolved

    There is another patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/67243 dealing with this kind of stuff. This whole class needs proper array access checks. But that's not part of this patch.

    ListController.php:51 Reply

    Done
  8. TYPO3com voted on patch set 2 V +1 01/16/21, 12:55 Completed build in 13m 30s on Sat, 16 Jan, 12:55 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8877

  9. Benni Mack voted on patch set 2 V +1 CR +1 01/19/21, 16:22

  10. Jochen Roth voted on patch set 2 V +1 CR +1 01/25/21, 10:29

  11. Benni Mack voted on patch set 2 V +2 CR +2 01/25/21, 10:41

  12. Benni Mack merged patch set 3 01/25/21, 10:41