Review main Abandoned

67452[BUGFIX] Show container controls, when inline record is deleted

Christian Eßl CR 0 V 0 Easy +1 −1 updated 01/27/21, 11:28

Commit message

Since refactoring of InlineControlContainer.js in TYPO3 10.4,
when an inline record element is deleted from a record with hidden
control buttons (because the maxitems limit was reached), the
controls would not be shown again.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 34

  1. Christian Eßl uploaded patch set 1 01/15/21, 07:27

  2. Oli Bartsch commented on patch set 1 01/15/21, 09:33

    Hi, the related patch should be https://review.typo3.org/c/Packages/TYPO3.CMS/+/66233. All a tags were replaced by buttons. So I suggest du use `button` only in the querySelector call. And please provide the JS for this change :)
  3. TYPO3com voted on patch set 1 V -1 01/16/21, 14:25 Completed build in 09m 35s on Sat, 16 Jan, 02:25 PM Test Summary: 1 of 32820 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8879

  4. Benni Mack abandoned the change 01/27/21, 11:28