67454[TASK] Add link to open original file from the edit view
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Oli Bartsch +1
-
Verified V +2 Done
- Richard Haeser +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1012
-
Kevin Appelt uploaded patch set 1 01/15/21, 16:37
-
TYPO3com voted on patch set 1 V +1 01/15/21, 16:47 Completed build in 09m 14s on Fri, 15 Jan, 04:47 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8869
-
Oli Bartsch commented on patch set 1 01/15/21, 19:28
Hi, first of all, I think this would be more a feature than a task. Even if it's a really small one. I personally however don't see the need of such button in that renderType. Its purpose is currently only to display basic information about the file. Enlarging it now with such buttons does not seem sensible to me. Especially because the UX looks odd e.g. when having an image in landscape format. Moreover does one usually access such record through either * the file list, where exactly this "show" button is right besides the edit button or * directly using the FormEngine inline relation controls, which also features the "info" button right besides the "edit" button. (The "info" button links to the ElementInformation, where again the "show" button is already present.) Adding such button now once again seems therefore superfluous and confuses me more than it helps. We already have so many buttons in the BE doing all the same. Just think of the countless possibilities to change the title of a page. However, this is just my personal feeling about it. I won't block this patch if others like the idea. :) -
Guido Schmechel commented on patch set 1 01/16/21, 12:57
Reply
I understand the intention of the patch. What do you think about a compromise? We have the "Location" line. Couldn't we create a link from it? That saves a button, but we still have the functionality. -
Oli Bartsch commented on patch set 1 01/18/21, 08:12
Reply
Yes, that would be a good solution. @Kevin do you agree with this change? -
Kevin Appelt uploaded patch set 2 01/18/21, 11:08
-
Kevin Appelt commented on patch set 2 01/18/21, 11:11
Reply
I think this is a good idea - I've changed the code to this solution. Maybe the style needs to be adjusted now (like underline the link?). What do you think? -
TYPO3com voted on patch set 2 V +1 01/18/21, 11:18 Completed build in 09m 13s on Mon, 18 Jan, 11:18 AM Test Summary: 32589 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8904
-
Richard Haeser commented on patch set 2 V +1 CR +1 01/19/21, 09:39
Reply
Although I would love to have links more "visible", I don't think we should do this within this patch. All text links are now without decoration and only on hover there is an underline. This is on several locations. So I think we should leave that for now and maybe check on a more general base how we want to handle text links in the backend. -
Oli Bartsch commented on patch set 2 V +1 CR +1 01/19/21, 13:39
Reply
Yep, it's just fine according to other links in BE. -
Richard Haeser voted on patch set 2 V +2 CR +2 01/19/21, 13:40
-
Richard Haeser merged patch set 3 01/19/21, 13:40