Review main Merged

67493[TASK] Replace GU::getIndpEnv('TYPO3_SSL') with normalizeParam option

Anja Leichsenring CR +2 V +2 Easy +19 −5 updated 04/27/21, 18:14

Commit message

This one occurence of the infamous getIndpEnv method can be replaced with
the requests normalizedParams information.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2134

Show 69 earlier messages
  1. Anja Leichsenring uploaded patch set 1 01/20/21, 19:49

  2. TYPO3com voted on patch set 1 V -1 01/20/21, 19:50 Completed build in 20s on Wed, 20 Jan, 07:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8942

  3. Anja Leichsenring uploaded patch set 2 01/20/21, 19:54

  4. TYPO3com voted on patch set 2 V +1 01/20/21, 20:03 Completed build in 08m 53s on Wed, 20 Jan, 08:03 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8943

  5. Benni Mack commented on patch set 2 01/20/21, 20:19

    This change is ready for review.

    UsernamePasswordLoginProvider.php:31 Unresolved

    needs to be "protected ?ServerRequestInterface $request" as it not set during constructor-time.

    UsernamePasswordLoginProvider.php:45 Unresolved

    what's with _GP() :D we could convert that as well :D

    UsernamePasswordLoginProvider.php:52 Unresolved

    ":void"
  6. Anja Leichsenring uploaded patch set 3 01/20/21, 20:40

  7. TYPO3com voted on patch set 3 V +1 01/20/21, 20:50 Completed build in 09m 11s on Wed, 20 Jan, 08:50 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8944

  8. Anja Leichsenring uploaded patch set 4 01/20/21, 20:54

  9. Anja Leichsenring uploaded patch set 5 01/20/21, 20:55

  1. Anja Leichsenring uploaded patch set 6 01/20/21, 20:59

  2. TYPO3com voted on patch set 4 V +1 01/20/21, 21:09 Completed build in 15m 06s on Wed, 20 Jan, 09:09 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8946

  3. TYPO3com voted on patch set 5 V +1 01/20/21, 21:14 Completed build in 09m 38s on Wed, 20 Jan, 09:14 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8947

  4. TYPO3com voted on patch set 6 V +1 01/20/21, 21:18 Completed build in 14m 08s on Wed, 20 Jan, 09:18 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8948

  5. Anja Leichsenring rebased onto patch set 7 04/06/21, 15:38

  6. TYPO3com voted on patch set 7 V +1 04/06/21, 15:46 Completed build in 07m 59s on Tue, 6 Apr, 03:46 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10497

  7. core-ci voted on patch set 7 V +1 04/06/21, 15:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2046

  8. Anja Leichsenring updated the commit message in patch set 8 04/06/21, 15:56

  9. Anja Leichsenring marked it ready for review 04/06/21, 15:57

  10. TYPO3com voted on patch set 8 V +1 04/06/21, 16:04 Completed build in 07m 35s on Tue, 6 Apr, 04:04 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10500

  11. core-ci voted on patch set 8 V +1 04/06/21, 16:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2049

  12. Benni Mack commented on patch set 8 04/14/21, 13:54

    LoginController.php:504

    A better alternative: $loginProvider->render() gets a 4th parameter or a separate method ->setRequest(ServerRequestInterface $request) which is called before the $loginProvider->render() method.
  13. Anja Leichsenring commented on patch set 8 04/17/21, 07:00

    LoginController.php:504 Reply Unresolved

    please see the discussion here, where this current solution has been agreed on: https://typo3.slack.com/archives/C03AM9R17/p1611172339121500
  14. Oli Bartsch rebased onto patch set 9 04/27/21, 16:38

  15. core-ci voted on patch set 9 V +1 04/27/21, 16:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10747

  16. Oli Bartsch uploaded patch set 10 04/27/21, 17:11

  17. Oli Bartsch voted on patch set 10 V +1 CR +1 04/27/21, 17:12

  18. Oli Bartsch commented on patch set 10 04/27/21, 17:19

    LoginController.php:342 Unresolved

    Should we move this on top of this method, so the request is also usable in the event?
  19. core-ci voted on patch set 10 V +1 04/27/21, 17:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10750

  20. Oli Bartsch uploaded patch set 11 04/27/21, 17:22

  21. Oli Bartsch voted on patch set 11 V +1 CR +1 04/27/21, 17:23

  22. core-ci voted on patch set 11 V +1 04/27/21, 17:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10751

  23. Benjamin Franzke voted on patch set 11 V +1 CR +1 04/27/21, 18:08

  24. Benjamin Franzke voted on patch set 11 V +2 CR +2 04/27/21, 18:14

  25. Benjamin Franzke merged patch set 12 04/27/21, 18:14