67493[TASK] Replace GU::getIndpEnv('TYPO3_SSL') with normalizeParam option
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 2
Review log 2134
Show 69 earlier messages
-
Anja Leichsenring uploaded patch set 1 01/20/21, 19:49
-
TYPO3com voted on patch set 1 V -1 01/20/21, 19:50 Completed build in 20s on Wed, 20 Jan, 07:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8942
-
Anja Leichsenring uploaded patch set 2 01/20/21, 19:54
-
TYPO3com voted on patch set 2 V +1 01/20/21, 20:03 Completed build in 08m 53s on Wed, 20 Jan, 08:03 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8943
-
Benni Mack commented on patch set 2 01/20/21, 20:19
This change is ready for review.UsernamePasswordLoginProvider.php:31Unresolvedneeds to be "protected ?ServerRequestInterface $request" as it not set during constructor-time.UsernamePasswordLoginProvider.php:45Unresolvedwhat's with _GP() :D we could convert that as well :DUsernamePasswordLoginProvider.php:52Unresolved":void" -
Anja Leichsenring uploaded patch set 3 01/20/21, 20:40
-
TYPO3com voted on patch set 3 V +1 01/20/21, 20:50 Completed build in 09m 11s on Wed, 20 Jan, 08:50 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8944
-
Anja Leichsenring uploaded patch set 4 01/20/21, 20:54
-
Anja Leichsenring uploaded patch set 5 01/20/21, 20:55
-
Anja Leichsenring uploaded patch set 6 01/20/21, 20:59
-
TYPO3com voted on patch set 4 V +1 01/20/21, 21:09 Completed build in 15m 06s on Wed, 20 Jan, 09:09 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8946
-
TYPO3com voted on patch set 5 V +1 01/20/21, 21:14 Completed build in 09m 38s on Wed, 20 Jan, 09:14 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8947
-
TYPO3com voted on patch set 6 V +1 01/20/21, 21:18 Completed build in 14m 08s on Wed, 20 Jan, 09:18 PM Test Summary: 32601 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-8948
-
Anja Leichsenring rebased onto patch set 7 04/06/21, 15:38
-
TYPO3com voted on patch set 7 V +1 04/06/21, 15:46 Completed build in 07m 59s on Tue, 6 Apr, 03:46 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10497
-
core-ci voted on patch set 7 V +1 04/06/21, 15:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2046
-
Anja Leichsenring updated the commit message in patch set 8 04/06/21, 15:56
-
Anja Leichsenring marked it ready for review 04/06/21, 15:57
-
TYPO3com voted on patch set 8 V +1 04/06/21, 16:04 Completed build in 07m 35s on Tue, 6 Apr, 04:04 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10500
-
core-ci voted on patch set 8 V +1 04/06/21, 16:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2049
-
Benni Mack commented on patch set 8 04/14/21, 13:54
LoginController.php:504A better alternative: $loginProvider->render() gets a 4th parameter or a separate method ->setRequest(ServerRequestInterface $request) which is called before the $loginProvider->render() method. -
Anja Leichsenring commented on patch set 8 04/17/21, 07:00
LoginController.php:504Reply Unresolvedplease see the discussion here, where this current solution has been agreed on: https://typo3.slack.com/archives/C03AM9R17/p1611172339121500 -
Oli Bartsch rebased onto patch set 9 04/27/21, 16:38
-
core-ci voted on patch set 9 V +1 04/27/21, 16:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10747
-
Oli Bartsch uploaded patch set 10 04/27/21, 17:11
-
Oli Bartsch voted on patch set 10 V +1 CR +1 04/27/21, 17:12
-
Oli Bartsch commented on patch set 10 04/27/21, 17:19
LoginController.php:342UnresolvedShould we move this on top of this method, so the request is also usable in the event? -
core-ci voted on patch set 10 V +1 04/27/21, 17:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10750
-
Oli Bartsch uploaded patch set 11 04/27/21, 17:22
-
Oli Bartsch voted on patch set 11 V +1 CR +1 04/27/21, 17:23
-
core-ci voted on patch set 11 V +1 04/27/21, 17:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10751
-
Benjamin Franzke voted on patch set 11 V +1 CR +1 04/27/21, 18:08
-
Benjamin Franzke voted on patch set 11 V +2 CR +2 04/27/21, 18:14
-
Benjamin Franzke merged patch set 12 04/27/21, 18:14