Review main Merged

67509[BUGFIX] Silently resolve invalid current page in paginator

Oli Bartsch CR +2 V +2 Normal +58 −8 updated 02/11/21, 13:32

Commit message

Passing a current page number which exceeds the maximum
number of pages to the paginator is now silently resolved
by using the last available page as the current page. This
is done to prevent empty results, since such value can be
passed unintentionally by a user. For example in case some
internal state changed after the view was initially rendered
or the view does not perform checks on this value at all.

The later will now be prevented at least in core by adding
the "max" attribute to all core paginations which previously
missed it.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6