Review main Merged

67590[BUGFIX] Make ext:form previous step button work again

Ralf Zimmermann CR +2 V +2 Easy +34 −2 updated 04/22/21, 06:08

Commit message

Since #92815 the extbase request dispatcher sets an "original
request" within a subrequest in case of a "ForwardResponse".

The fluid AbstractFormFieldViewHelper::hasMappingErrorOccurred()
guesses that a property mapping error exists as soon as a request
is a subrequest. This is determined by the fact that the current
request has a original request (e.g. if a controller returns a
ForwardResponse).

While the determination of "property mapping error exists" based
on the existence of a parent request may not be the best indicator,
it seems to be fine for EXT:form for now.

EXT:form makes further use of the HiddenViewHelper to set the previous
page index as a value for the property "__currentPage". Since this
ViewHelper always sets the respectSubmittedDataValue property to TRUE,
the value is always overwritten in case a parent request exists and
the "previous step" button did not longer work.

This is now fixed by making the respectSubmittedDataValue property
configurable via a ViewHelper argument and setting in to FALSE for
the "__currentPage" field.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3